Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: internal entity removal #1467

Merged
merged 4 commits into from
Sep 26, 2024
Merged

chore: internal entity removal #1467

merged 4 commits into from
Sep 26, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Sep 25, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Internal entity removal from frontend

Motivation and Context

How did you test it?

Create a internal user and check for that particular user to test all the flows

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the S-blocked Status: Blocked on something else or other implementation work label Sep 25, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Sep 25, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner September 25, 2024 09:42
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed chore chore user-management Status: issues related to user management and removed S-blocked Status: Blocked on something else or other implementation work labels Sep 25, 2024
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Sep 25, 2024 that may be closed by this pull request
chore: internal entity removal #1468
Closed
PritishBudhiraja
PritishBudhiraja approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️✨ Looks good to me.

@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 4c94b8d Sep 26, 2024
9 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the internal-entity-removal branch September 26, 2024 17:17
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed chore chore user-management Status: issues related to user management labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: internal entity removal
3 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104