Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed compiler warning and threeds comp change #1478

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Sep 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

image

Motivation and Context

remove redundant code & remove compiler warning

How did you test it?

connect three ds connector
check the connected connector
three dots previously seen in top right corner are removed

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 requested a review from a team as a code owner September 26, 2024 11:04
Copy link

Review changes with SemanticDiff.

@gitanjli525 gitanjli525 self-assigned this Sep 26, 2024
@gitanjli525 gitanjli525 linked an issue Sep 26, 2024 that may be closed by this pull request
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug labels Sep 26, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 2999335 Sep 26, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the fix-bugs- branch September 26, 2024 11:50
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE]: removed menu options from 3ds and remove compiler warning
4 participants