Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metric selector and tabs for new analytics module #1485

Merged
merged 9 commits into from
Sep 27, 2024
Merged

feat: metric selector and tabs for new analytics module #1485

merged 9 commits into from
Sep 27, 2024

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Sep 26, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added a metric selctor and goubby tabs and granuarity tabs for new analytics module
image
image
image

Motivation and Context

How did you test it?

enable the new analytics feature flag and the metric selector tab for proccessed amoutn should change the value displayed on the line graph and the groupby should change the disstripbution type and teh granuality should change the bucket size

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Sep 26, 2024
@sagarnaikjuspay sagarnaikjuspay self-assigned this Sep 26, 2024
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner September 26, 2024 17:55
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@sagarnaikjuspay sagarnaikjuspay linked an issue Sep 26, 2024 that may be closed by this pull request
Implement Metric selector component #1369
Closed
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 511ee1e Sep 27, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the comparision-filter branch September 27, 2024 13:21
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitanjli525 gitanjli525 gitanjli525 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Metric selector component
4 participants
@sagarnaikjuspay @gitanjli525 @JeevaRamu0104 @prajwalnl0