Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unauthorised page issue #1588

Merged
merged 19 commits into from
Oct 14, 2024
Merged

fix: unauthorised page issue #1588

merged 19 commits into from
Oct 14, 2024

Conversation

JeevaRamu0104
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 commented Oct 10, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Facing unauthorised page on switching the merchant and profile in the user page.This is due to because the screen state is not set to loading during the user role api is called.
Now screen state is set to loading while calling the user roles api.

Motivation and Context

Screen.Recording.2024-10-10.at.1.43.28.PM.mov

How did you test it?

unauthorised page shouldn't appear during org or merchant or profile switch.Check payment page

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@JeevaRamu0104 JeevaRamu0104 added the bug bug label Oct 10, 2024
@JeevaRamu0104 JeevaRamu0104 self-assigned this Oct 10, 2024
@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner October 10, 2024 10:21
Copy link

Review changes with SemanticDiff.

@JeevaRamu0104 JeevaRamu0104 added the S-blocked Status: Blocked on something else or other implementation work label Oct 14, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 8241854 Oct 14, 2024
6 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the fix-unauthorized-issue branch October 14, 2024 11:04
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-blocked Status: Blocked on something else or other implementation work bug bug labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unauthorized page appears while selecting merchant and profile in invite users page.
3 participants