chore: create separate webpack #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 2 files.
|
JeevaRamu0104
added
chore
JeevaRamu0104
changed the title
JeevaRamu0104
added
S-waiting-on-review
gitanjli525
reviewed
Oct 14, 2024
gitanjli525
previously approved these changes
Oct 15, 2024
Riddhiagrawal001
previously approved these changes
Oct 15, 2024
|
LGTM |
sagarnaikjuspay
previously approved these changes
Oct 15, 2024
…ch-control-center into create-seperate-webpack
JeevaRamu0104
dismissed stale reviews from sagarnaikjuspay, Riddhiagrawal001, and gitanjli525
via
7e29d3b
gitanjli525
approved these changes
Oct 21, 2024
kanikabansal-juspay
approved these changes
Oct 21, 2024
github-actions
bot
added
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Current webpack build is building with public folder which contains the static assets.Added new webpack configuration which ignores copying the static assets
Motivation and Context
How did you test it?
All the icons should appear even after doing this deployment
Where to test it?
Checklist
npm run re:build