Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: overview section spacing fix and payments metrics changes #1600

Merged
merged 2 commits into from
Oct 15, 2024
Merged

chore: overview section spacing fix and payments metrics changes #1600

merged 2 commits into from
Oct 15, 2024

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Oct 15, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

overvew section the made the gap between the tiles as 24px as in design and metrics name changes from payment_processed_amount to sessionized_payment_processed_amount and payment_count to sessionized_payment_processed_count and the url is changed to V2
Screenshot 2024-10-15 at 6 34 12 AM

Motivation and Context

How did you test it?

the new metrics should return the values correctly that is payment proccesed amount and paym ent count

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner October 15, 2024 05:38
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@sagarnaikjuspay sagarnaikjuspay self-assigned this Oct 15, 2024
@sagarnaikjuspay sagarnaikjuspay linked an issue Oct 15, 2024 that may be closed by this pull request
overview section spacing fix and payments metrics changes #1601
Closed
@sagarnaikjuspay sagarnaikjuspay added analytics S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 15, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 37ea150 Oct 15, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the metric-change-payment-processed branch October 15, 2024 07:40
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitanjli525 gitanjli525 gitanjli525 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overview section spacing fix and payments metrics changes
4 participants
@sagarnaikjuspay @gitanjli525 @JeevaRamu0104 @prajwalnl0