fix: merchant account credentials not shown in profile view #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
11 tasks
kanikabansal-juspay
added
C-bug
JeevaRamu0104
approved these changes
Oct 22, 2024
gitanjli525
approved these changes
Oct 23, 2024
github-actions
bot
added
Closed
|
@prajwalnl0, @kanikabansal-juspay, can you let me know once this is deployed in prod. ++ @JeevaRamu0104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Initially we were conditionally not rendering merchant id and publishable key on home at user profile view but the credentials were shown in merchant account api response. Ideally profile user should not know any credentials and information regarding merchant.
Motivation and Context
To enforce stricter access control.
How did you test it?
I checked the if the profile view was rendering without any display of credentials .
Where to test it?
Checklist
npm run re:build