Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make auto retry value field mandatory #1632

Merged
merged 8 commits into from
Oct 21, 2024
Merged

fix: make auto retry value field mandatory #1632

merged 8 commits into from
Oct 21, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Oct 17, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • making the max auto retry value field mandatory in case of auto retry is enabled

image

Motivation and Context

How did you test it?

  1. Go to payment settings
  2. enable auto retry toggle
  3. try clicking update
  4. update button shows error tooltip and is disabled

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Oct 17, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner October 17, 2024 19:31
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 17, 2024
Riddhiagrawal001
Riddhiagrawal001 reviewed Oct 18, 2024
View reviewed changes
src/screens/Developer/PaymentSettings/PaymentSettings.res Outdated Show resolved Hide resolved
src/screens/Developer/APIKeys/DeveloperUtils.res Outdated Show resolved Hide resolved
src/screens/Settings/MerchantAccountUtils.res Outdated Show resolved Hide resolved
src/utils/LogicUtils.res Outdated Show resolved Hide resolved
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit e80706e Oct 21, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the auto-retry-value branch October 21, 2024 13:09
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gitanjli525 @Riddhiagrawal001 @sagarnaikjuspay @prajwalnl0