Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: card-network issue fix and removed calendly link #1637

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Card-network is not filtering the total count. Hence disabling the card-network filter from FE . Also removed calendly link

Motivation and Context

How did you test it?

Card-network shoudn't come in filter options in payments filter

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner October 22, 2024 11:28
Copy link

Review changes with SemanticDiff.

@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Oct 22, 2024
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 changed the title Card network issue fix fix: card-network issue fix and removed calendly link Oct 22, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Oct 22, 2024 that may be closed by this pull request
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit ed43df1 Oct 22, 2024
7 of 9 checks passed
@prajwalnl0 prajwalnl0 deleted the card-network-issue-fix branch October 22, 2024 12:03
@github-actions github-actions bot added the Closed Applied to issues or pull requests that have been successfully resolved or completed label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

card-network removal from filters and calendly link removal
4 participants