Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cluttered package json refactor #1649

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PritishBudhiraja
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Cluttered Package JSON fix

Motivation and Context

Same things were written and can be reduced for better readability.

How did you test it?

via running basic commands - npm run re:start, npm run start, npm run build

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 24, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Oct 24, 2024
@PritishBudhiraja PritishBudhiraja requested a review from a team as a code owner October 24, 2024 07:46
Copy link

semanticdiff-com bot commented Oct 24, 2024

Review changes with SemanticDiff.

Analyzed 3 of 3 files.

Overall, the semantic diff is 41% smaller than the GitHub diff.

Filename Status
✔️ package-lock.json 62.59% smaller
✔️ package.json 42.76% smaller
✔️ src/server/health.mjs Analyzed

@PritishBudhiraja PritishBudhiraja linked an issue Oct 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: cluttered package json refactor
2 participants