feat: add samsung pay payment method support for cybersource #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
JeevaRamu0104
added
the
S-blocked
JeevaRamu0104
added
core
JeevaRamu0104
added
the
S-waiting-on-review
gitanjli525
reviewed
Oct 25, 2024
| ->getArrayFromDict("countries", []) | ||
| ->Array.map(item => { | ||
| let dict = item->getDictFromJsonObject | ||
| let a: SelectBox.dropdownOption = { |
There was a problem hiding this comment.
pls update the variable name
gitanjli525
reviewed
Oct 25, 2024
| @@ -1404,6 +1407,7 @@ let itemToPMAuthMapper = dict => { | |||
| let constructConnectorRequestBody = (wasmRequest: wasmRequest, payload: JSON.t) => { | |||
| open LogicUtils | |||
| let dict = payload->getDictFromJsonObject | |||
| Js.log2(dict, "DICT") | |||
There was a problem hiding this comment.
please remove this log
gitanjli525
reviewed
Oct 25, 2024
| let samsungPayFields = React.useMemo(() => { | ||
| try { | ||
| if connector->isNonEmptyString { | ||
| let dict = |
gitanjli525
reviewed
Oct 25, 2024
| @@ -111,7 +112,8 @@ let make = ( | |||
| </h2> | |||
| </div> | |||
| <div className="self-center"> | |||
| <Button text="Proceed" buttonType={Primary} onClick={_ => onSubmit()->ignore} /> | |||
| // <Button text="Proceed" buttonType={Primary} onClick={_ => onSubmit()->ignore} /> | |||
gitanjli525
reviewed
Oct 25, 2024
| @@ -152,6 +152,8 @@ let getPaymentMethodTypeFromString = paymentMethodType => { | |||
| | "apple_pay" => ApplePay | |||
| | "paypal" => PayPal | |||
| | "open_banking_pis" => OpenBankingPIS | |||
| | "samsung_pay" => SamsungPay | |||
|
|
|||
There was a problem hiding this comment.
empty line addition not required here
gitanjli525
reviewed
Oct 25, 2024
| | Select => selectInput(~field={samsungPayField}, ~formName) | ||
| | MultiSelect => multiSelectInput(~field={samsungPayField}, ~formName) | ||
| | Radio => radioInput(~field={samsungPayField}, ~formName, ~fill, ()) | ||
|
|
There was a problem hiding this comment.
pls remove empty line addition
| setScreenState(_ => Loading) | ||
| let paymentMethoConfigUrl = getURL(~entityName=PAYMENT_METHOD_CONFIG, ~methodType=Get) | ||
| let res = await fetchDetails( | ||
| `${paymentMethoConfigUrl}?connector=${connector}&paymentMethodType=apple_pay`, |
There was a problem hiding this comment.
${paymentMethoConfigUrl}?connector=${connector}&paymentMethodType=apple_pay,
Will there be paymentMethodType = applePay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Motivation and Context
How did you test it?
Under cybersource wallet you should find samsung pay as one of the payment method
Where to test it?
Checklist
npm run re:build