Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes to enable card-network #1655

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: changes to enable card-network #1655

merged 2 commits into from
Oct 28, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Oct 25, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Card-network was disabled from FE . This will enable the card-network filter from FE

Motivation and Context

How did you test it?

card-network should be visible in FE in filters

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the bug bug label Oct 25, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Oct 25, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner October 25, 2024 08:29
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@Riddhiagrawal001 Riddhiagrawal001 linked an issue Oct 25, 2024 that may be closed by this pull request
fix: changes to enable card-network #1656
Closed
PritishBudhiraja
PritishBudhiraja approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit d910c1e Oct 28, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the card-network-enable branch October 28, 2024 05:24
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed bug bug labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@gitanjli525 gitanjli525 gitanjli525 approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: changes to enable card-network
4 participants
@Riddhiagrawal001 @PritishBudhiraja @gitanjli525 @prajwalnl0