fix(router): change Not Found response to Internal Server Error for empty vector

[shreyshukla29]

…ctor (#5916)

Modified the get_aggregates_for_payments function to address issue #5916.

• Replaced the to_not_found_response handler with map_err to handle internal errors during data fetching.
• Ensured that an empty vector returned from the get_intent_status_with_count method is treated as valid and does not result in a "Not Found" error.
• Now, an Internal Server Error (HTTP 500) is returned only when there is an actual problem with fetching data from the database.
• Attached a descriptive error message using attach_printable to provide more context in case of internal errors.

This fix ensures that valid empty results no longer cause false error responses and internal issues are correctly flagged with a 500 error.

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 55% smaller than the GitHub diff.

	Filename	Status
✔️	crates/router/src/core/payments.rs	54.89% smaller

[gorakhnathy7]

Hey @shreyshukla29 Any update on changes?

[shreyshukla29]

Hey @shreyshukla29 Any update on changes?

I’ve been reviewing the suggestions and working on implementing the changes to the get_aggregates_for_payments function. I plan to utilize the .change_context(errors::ApiErrorResponse::InternalServerError) method to enhance error handling.

[shreyshukla29]

Hi @gorakhnathy7 ,

Thanks for following up! I wanted to let you know that I’ve been reviewing the code, but it appears that the get_aggregates_for_payments function is not present in the recent branch, and the branch I’m working from seems to be outdated.

Could you please confirm if there’s a newer branch I should be looking at? I want to ensure that my changes are aligned with the latest codebase.

Thanks for your help!

Best,
Shrey