Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(core): interpolate params with their specific values #6448

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Refactor(core): interpolate params with their specific values #6448

wants to merge 6 commits into from
+113 −23

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner October 28, 2024 08:12
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 28, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 4 of 6 files.

Filename Status
❔ crates/router/Cargo.toml Unsupported file format
✔️ crates/router/src/core/payments.rs 92.31% smaller
✔️ crates/router/src/core/payments/routing.rs 3.99% smaller
✔️ crates/external_services/src/grpc_client/dynamic_routing.rs Analyzed
✔️ crates/api_models/src/routing.rs Analyzed
❔ config/development.toml Unsupported file format

@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft October 28, 2024 08:12
@prajjwalkumar17 prajjwalkumar17 changed the title Refactor/grpc sr Refactor(core): interpolate params with their specific values Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prajjwalkumar17