Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Novalnet] Remove webhook placeholder connector config #6451

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(connector): [Novalnet] Remove webhook placeholder connector config #6451

merged 1 commit into from
Oct 28, 2024
+0 −3

Conversation

cookieg13
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

remove placeholder from novalnet webhooks secret

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@cookieg13 cookieg13 requested a review from a team as a code owner October 28, 2024 11:12
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@cookieg13 cookieg13 self-assigned this Oct 28, 2024
@cookieg13 cookieg13 changed the title remove placeholder from novalnet webhooks secret [BUG] There should not be any placeholder in Novalnet webhooks secret Oct 28, 2024
@likhinbopanna likhinbopanna changed the title [BUG] There should not be any placeholder in Novalnet webhooks secret [Fix] There should not be any placeholder in Novalnet webhooks secret Oct 28, 2024
@srujanchikke srujanchikke changed the title [Fix] There should not be any placeholder in Novalnet webhooks secret fix(connector): [Novalnet] Remove webhook placeholder connector config Oct 28, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e33340e Oct 28, 2024
25 of 29 checks passed
@likhinbopanna likhinbopanna deleted the bugfixPlaceholder branch October 28, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@cookieg13 cookieg13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cookieg13 @JeevaRamu0104 @srujanchikke @likhinbopanna