Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dispute): change dispute currency type to currency enum #6454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ImSagnik007
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Changed Dispute Currency from String to ENUM.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ImSagnik007 ImSagnik007 requested review from a team as code owners October 28, 2024 13:17
Copy link

semanticdiff-com bot commented Oct 28, 2024

Review changes with SemanticDiff.

Analyzed 21 of 23 files.

Overall, the semantic diff is 3% smaller than the GitHub diff.

File Information
Filename Status
migrations/2024-10-28-125949_change_currency_type_in_dispute/down.sql Unsupported file format
migrations/2024-10-28-125949_change_currency_type_in_dispute/up.sql Unsupported file format
✔️ crates/router/src/types/storage/dispute.rs 30.63% smaller
✔️ crates/router/src/services/kafka/dispute.rs Analyzed
✔️ crates/router/src/services/kafka/dispute_event.rs Analyzed
✔️ crates/router/src/db/dispute.rs 37.49% smaller
✔️ crates/router/src/connector/adyen.rs Analyzed
✔️ crates/router/src/connector/airwallex.rs Analyzed
✔️ crates/router/src/connector/bluesnap.rs Analyzed
✔️ crates/router/src/connector/braintree.rs Analyzed
✔️ crates/router/src/connector/checkout.rs Analyzed
✔️ crates/router/src/connector/payme.rs Analyzed
✔️ crates/router/src/connector/paypal.rs Analyzed
✔️ crates/router/src/connector/rapyd.rs Analyzed
✔️ crates/router/src/connector/stripe.rs Analyzed
✔️ crates/router/src/connector/trustpay.rs Analyzed
✔️ crates/router/src/connector/utils.rs Analyzed
✔️ crates/router/src/compatibility/stripe/webhooks.rs 2.64% smaller
✔️ crates/hyperswitch_interfaces/src/disputes.rs Analyzed
✔️ crates/diesel_models/src/dispute.rs Analyzed
✔️ crates/diesel_models/src/schema.rs 49.14% smaller
✔️ crates/diesel_models/src/schema_v2.rs 49.14% smaller
✔️ crates/api_models/src/disputes.rs Analyzed

@ImSagnik007 ImSagnik007 self-assigned this Oct 28, 2024
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant