Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(address): change address to domain address in application #6608

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • Refactoring

Description

A new type has been added to the domain models called Address. This type has been used in the application everywhere where we use address.

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Narayanbhat166 Narayanbhat166 added the C-refactor Category: Refactor label Nov 19, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this Nov 19, 2024
Copy link

semanticdiff-com bot commented Nov 19, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/paypal/transformers.rs  89% smaller
  crates/router/src/core/payout_link.rs  85% smaller
  crates/router/src/core/payments/operations/payment_confirm.rs  82% smaller
  crates/router/src/core/payments/operations/payment_create.rs  82% smaller
  crates/hyperswitch_connectors/src/connectors/shift4/transformers.rs  82% smaller
  crates/router/src/connector/utils.rs  77% smaller
  crates/router/src/compatibility/stripe/payment_intents/types.rs  74% smaller
  crates/router/src/connector/adyen/transformers.rs  73% smaller
  crates/router/src/connector/wellsfargo/transformers.rs  73% smaller
  crates/router/src/connector/riskified/transformers/api.rs  71% smaller
  crates/hyperswitch_connectors/src/connectors/dlocal/transformers.rs  69% smaller
  crates/hyperswitch_domain_models/src/address.rs  67% smaller
  crates/router/src/core/payouts.rs  66% smaller
  crates/router/src/types/transformers.rs  64% smaller
  crates/router/src/connector/gocardless/transformers.rs  58% smaller
  crates/router/src/core/payment_methods.rs  56% smaller
  crates/router/src/connector/cybersource/transformers.rs  45% smaller
  crates/router/tests/connectors/dlocal.rs  43% smaller
  crates/hyperswitch_connectors/src/connectors/worldline/transformers.rs  41% smaller
  crates/router/tests/connectors/airwallex.rs  32% smaller
  crates/router/tests/connectors/multisafepay.rs  32% smaller
  crates/router/tests/connectors/wise.rs  32% smaller
  crates/router/tests/connectors/worldline.rs  32% smaller
  crates/hyperswitch_connectors/src/connectors/mollie/transformers.rs  32% smaller
  crates/router/tests/connectors/adyen.rs  32% smaller
  crates/router/src/connector/netcetera/netcetera_types.rs  22% smaller
  crates/router/src/core/payments/transformers.rs  17% smaller
  crates/hyperswitch_domain_models/src/payments.rs  16% smaller
  crates/hyperswitch_domain_models/src/payments/payment_attempt.rs  15% smaller
  crates/router/tests/connectors/utils.rs  11% smaller
  crates/router/src/connector/wise/transformers.rs  4% smaller
  crates/hyperswitch_domain_models/src/router_request_types.rs  1% smaller
  crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs  1% smaller
  crates/router/tests/connectors/globalpay.rs  1% smaller
  api-reference-v2/openapi_spec.json  0% smaller
  crates/api_models/src/payments.rs  0% smaller
  crates/common_enums/src/enums.rs  0% smaller
  crates/hyperswitch_connectors/src/utils.rs  0% smaller
  crates/hyperswitch_domain_models/src/payment_address.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types/authentication.rs  0% smaller
  crates/router/src/connector/bankofamerica/transformers.rs  0% smaller
  crates/router/src/connector/bluesnap/transformers.rs  0% smaller
  crates/router/src/connector/klarna/transformers.rs  0% smaller
  crates/router/src/core/authentication.rs  0% smaller
  crates/router/src/core/authentication/transformers.rs  0% smaller
  crates/router/src/core/payment_methods/surcharge_decision_configs.rs  0% smaller
  crates/router/src/core/payments.rs  0% smaller
  crates/router/src/core/payments/operations/payment_confirm_intent.rs  0% smaller
  crates/router/src/core/payments/operations/payment_get.rs  0% smaller
  crates/router/src/core/payments/operations/payment_response.rs  0% smaller
  crates/router/src/core/payments/operations/tax_calculation.rs  0% smaller
  crates/router/src/core/payments/routing.rs  0% smaller
  crates/router/src/core/payments/tokenization.rs  0% smaller
  crates/router/src/core/utils.rs  0% smaller
  crates/router/src/types.rs  0% smaller
  crates/router/tests/connectors/aci.rs  0% smaller
  crates/router/tests/connectors/bitpay.rs  0% smaller
  crates/router/tests/connectors/bluesnap.rs  0% smaller
  crates/router/tests/connectors/cashtocode.rs  0% smaller
  crates/router/tests/connectors/coinbase.rs  0% smaller
  crates/router/tests/connectors/cryptopay.rs  0% smaller
  crates/router/tests/connectors/cybersource.rs  0% smaller
  crates/router/tests/connectors/forte.rs  0% smaller
  crates/router/tests/connectors/iatapay.rs  0% smaller
  crates/router/tests/connectors/opennode.rs  0% smaller
  crates/router/tests/connectors/payeezy.rs  0% smaller
  crates/router/tests/connectors/payme.rs  0% smaller
  crates/router/tests/connectors/trustpay.rs  0% smaller

@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Nov 21, 2024
Base automatically changed from add_address_for_v2 to main November 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants