feat(connector): [Novalnet] Add zero auth mandate #6631
Conversation
|
Review changes with Changed Files
|
cookieg13
changed the title
cookieg13
force-pushed
the
addNovalnetSetupMandate
branch
from
df85bb8
to
4fdf8c1
Compare
| let enforce_3d = match item.auth_type { | ||
| enums::AuthenticationType::ThreeDs => Some(1), | ||
| enums::AuthenticationType::NoThreeDs => None, | ||
| }; | ||
| let test_mode = match item.test_mode { | ||
| Some(true) => 1, | ||
| Some(false) | None => 0, | ||
| }; |
There was a problem hiding this comment.
Should we consider using constants or enums here?
| mobile: item.get_optional_billing_phone_number(), | ||
| billing: Some(billing), | ||
| // no_nc is used to indicate if minimal customer data is passed or not | ||
| no_nc: 1, |
There was a problem hiding this comment.
We can use constants here.
| let custom = NovalnetCustom { lang }; | ||
| let hook_url = item.request.get_webhook_url()?; | ||
| let return_url = item.request.get_return_url()?; | ||
| let create_token = Some(1); |
| let webhook_url = Some(helpers::create_webhook_url( | ||
| router_base_url, | ||
| &attempt.merchant_id, | ||
| connector_name, | ||
| )); |
There was a problem hiding this comment.
@Narayanbhat166 @sai-harsha-vardhan Should we consider passing MerchantConnectorAccountId here, instead of the connector name? Basically update the create_webhook_url() function as well?
There was a problem hiding this comment.
Yes, it's always recommended to use MerchantConnectorAccountId in webhook url
There was a problem hiding this comment.
@sai-harsha-vardhan @SanchithHegde I made a new fn create_webhook_url_using_mca_id ,but only used it in line 226 (crates/router/src/core/payments/transformers.rs:226) . In the other places where create_webhook_url() is currently used the MerchantConnectorAccountId value is Optional, so we cant replace connector name with simply MerchantConnectorAccountId.
There was a problem hiding this comment.
we will always have the merchant_connector_id when constructing the router data. So if it is not found you can raise an internal server error.
I do not see any harm in updating the existing webhook function.
cookieg13
force-pushed
the
addNovalnetSetupMandate
branch
from
4fdf8c1
to
0b20c37
Compare
cookieg13
force-pushed
the
addNovalnetSetupMandate
branch
from
0b20c37
to
73667aa
Compare
cookieg13
force-pushed
the
addNovalnetSetupMandate
branch
from
0fd4b9a
to
64d9202
Compare
Type of Change
Description
Added zero auth mandates for Novalnet
Additional Changes
Motivation and Context
How did you test it?
Tested manually
https://docs.google.com/document/d/1i4SSX837Dh9ipfOz24bDwJF8osR_UPmfPLWUbLP3bh0/edit?usp=sharing
Checklist
cargo +nightly fmt --allcargo clippy