Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats #6853

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Dec 16, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This change will add payment_method_type in dynamic_routing_stats.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing can be done in following way:

  1. Enable Success based routing for a profile with feature as metrics.
  2. Make a payment.
  3. Search the dynamic_routing_stats table for the new col. payment_method_type for that payment.
Screenshot 2024-12-16 at 5 38 33 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added M-database-changes Metadata: This PR involves database schema changes C-refactor Category: Refactor labels Dec 16, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the December 2024 Release milestone Dec 16, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Dec 16, 2024
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners December 16, 2024 12:13
Copy link

semanticdiff-com bot commented Dec 16, 2024

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 492fd87 Dec 20, 2024
16 of 18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add_pmt_in_dynamic_routing_stats branch December 20, 2024 08:33
pixincreate added a commit that referenced this pull request Dec 20, 2024
…ete-pm

* 'main' of github.com:juspay/hyperswitch:
  refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats (#6853)
  refactor(customers_v2): include minor fixes for customer v2 flows (#6876)
  fix: cypress reports generation (#6894)
  fix(connector): Paypal BankRedirects (Ideal/EPS)  (#6864)
  chore(version): 2024.12.19.1
  fix(connector): [UNIFIED_AUTHENTICATION_SERVICE] change url path to `pre_authentication_processing` in pre-auth flow (#6885)
  refactor(users): move roles schema to global interface (#6862)
  feat(payment_methods): add support to pass apple pay recurring details to obtain apple pay merchant token (#6770)
  feat(payments): [Payment links] Add config for changing button text for payment links (#6860)
  feat(core): added customer phone_number and email to session token response for click to pay (#6863)
  FEAT(klarna): Klarna Kustom Checkout Integration (#6839)
  feat(users): handle email url for users in different tenancies (#6809)
  chore(version): 2024.12.19.0
  refactor(dynamic_routing): update the authentication for update config to include JWT type (#6785)
  chore(env): remove unified_authentication_service base_url from integ, sandbox and production toml (#6865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats
4 participants