Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dynamic_routing): add non_deterministic value in SuccessBasedRoutingConclusiveState type #6878

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(dynamic_routing): add non_deterministic value in SuccessBasedRoutingConclusiveState type #6878

wants to merge 2 commits into from
+14 −0

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Dec 18, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will add a value non_deterministic in SuccessBasedRoutingConclusiveState type.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  1. Toggle Success Based routing for the merchant.
curl --location --request POST 'http://localhost:8080/account/xxxxxx/business_profile/xxxxxxx/dynamic_routing/success_based/toggle?enable=metrics' \
--header 'api-key: xxxxxxx'
  1. Create a payment that goes in processing state or any non terminal state.
  2. Check the dynamic_routing_stats table for the payment_id for the non_determinisctic.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added the C-refactor Category: Refactor label Dec 18, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Dec 18, 2024
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner December 18, 2024 13:01
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@prajjwalkumar17 prajjwalkumar17 added this to the December 2024 Release milestone Dec 18, 2024
@prajjwalkumar17 prajjwalkumar17 linked an issue Dec 18, 2024 that may be closed by this pull request
refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats #6854
Closed
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Chethan-rao Chethan-rao Awaiting requested review from Chethan-rao

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
C-refactor Category: Refactor M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
December 2024 Release
Development

Successfully merging this pull request may close these issues.

refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats
3 participants
@prajjwalkumar17 @SanchithHegde @Narayanbhat166