New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(currency_conversion): re frame the crate to make api calls on background thread #6906

Draft

prajjwalkumar17 wants to merge 2 commits into main from reframe_forex

Contributor

prajjwalkumar17 commented Dec 20, 2024

Type of Change

Description

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible


          add background thread for api calls

140853d

prajjwalkumar17 self-assigned this

prajjwalkumar17 requested a review from a team as a code owner

December 20, 2024 06:29

semanticdiff-com bot commented Dec 20, 2024 •

edited

Loading

Review changes with

Changed Files

File	Status
crates/router/src/core/currency.rs	85% smaller
crates/router/src/utils/currency.rs	30% smaller

prajjwalkumar17 marked this pull request as draft

December 20, 2024 06:30


          minor refactors

e47e921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet