Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connectors): fiuu,novalnet,worldpay - extend NTI flows #6946

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Dec 26, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #6941

This PR adds NTI flow integrations for below connectors

  • Fiuu - store NTI ID in payment_methods from connector's PSync response
  • Novalnet - use NTI ID for card payments
  • Worldpay - store and use NTI ID for card payments

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

1. CIT for cards through Adyen

cURL

curl --location --request POST 'http://localhost:8080/payments' \
    --header 'Content-Type: application/json' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_rh7Gdbe4bpB4Vxz9A7SQge8NwmI48LHgckedcW181ltQ5xJte0ADtOBsW7tmQaI0' \
    --data-raw '{"amount":100,"currency":"USD","confirm":true,"capture_method":"automatic","capture_on":"2022-09-10T10:11:12Z","customer_id":"cus_VzApV1FxWKoB90X5uEcm","email":"[email protected]","name":"John Doe","phone":"999999999","profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","phone_country_code":"+65","description":"Its my first payment request","authentication_type":"no_three_ds","return_url":"https://hyperswitch.io","setup_future_usage":"off_session","customer_acceptance":{"acceptance_type":"online","accepted_at":"1963-05-03T04:07:52.723Z","online":{"ip_address":"127.0.0.1","user_agent":"amet irure esse"}},"connector":["adyen"],"payment_method":"card","payment_method_data":{"card":{"card_number":"5454545454545454","card_exp_month":"03","card_exp_year":"2030","card_cvc":"737","nick_name":"JD"},"billing":{"email":"[email protected]","address":{"first_name":"John","last_name":"US"}}},"billing":{"address":{"line1":"1467","line2":"Harrison Street","line3":"Harrison Street","city":"San Fransico","state":"California","zip":"94122","country":"US","first_name":"John","last_name":"US"}},"statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","metadata":{"udf1":"value1","new_customer":"true","login_date":"2019-09-10T10:11:12Z"},"browser_info":{"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","language":"en-US","color_depth":32,"screen_height":1117,"screen_width":1728,"time_zone":-330,"java_enabled":true,"java_script_enabled":true}}'

Response

{"payment_id":"pay_lVqK4xVFlhPsDKVArnIo","merchant_id":"merchant_1735800357","status":"requires_customer_action","amount":100,"net_amount":100,"shipping_cost":null,"amount_capturable":100,"amount_received":null,"connector":"adyen","client_secret":"pay_lVqK4xVFlhPsDKVArnIo_secret_jge63cwkJDCY1FZMzOeR","created":"2025-01-02T08:27:51.185Z","currency":"USD","customer_id":"cus_VzApV1FxWKoB90X5uEcm","customer":{"id":"cus_VzApV1FxWKoB90X5uEcm","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+65"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":"off_session","off_session":null,"capture_on":null,"capture_method":"automatic","payment_method":"card","payment_method_data":{"card":{"last4":"5454","card_type":"CREDIT","card_network":"Mastercard","card_issuer":"BANKHANDLOWYWWARSZAWIE.S.A.","card_issuing_country":"POLAND","card_isin":"545454","card_extended_bin":null,"card_exp_month":"03","card_exp_year":"2030","card_holder_name":"John US","payment_checks":null,"authentication_data":null},"billing":{"address":{"city":null,"country":null,"line1":null,"line2":null,"line3":null,"zip":null,"state":null,"first_name":"John","last_name":"US"},"phone":null,"email":"[email protected]"}},"payment_token":null,"shipping":null,"billing":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"John","last_name":"US"},"phone":null,"email":null},"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://hyperswitch.io/","authentication_type":"no_three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":{"type":"redirect_to_url","redirect_to_url":"http://localhost:8080/payments/redirect/pay_lVqK4xVFlhPsDKVArnIo/merchant_1735800357/pay_lVqK4xVFlhPsDKVArnIo_1"},"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"credit","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"cus_VzApV1FxWKoB90X5uEcm","created_at":1735806471,"expires":1735810071,"secret":"epk_d3cf3844e1144988bb2bf79bb9f0d8bf"},"manual_retry_allowed":null,"connector_transaction_id":"Z3S5HHVH5S5H3275","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":"Z3S5HHVH5S5H3275","payment_link":null,"profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_Vcy2aZeTpgwfuzHd79R3","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-01-02T08:42:51.185Z","fingerprint":null,"browser_info":{"language":"en-US","time_zone":-330,"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","color_depth":32,"java_enabled":true,"screen_width":1728,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":1117,"java_script_enabled":true},"payment_method_id":"pm_MO7c0p19Rgc2p6nDSWCd","payment_method_status":"inactive","updated":"2025-01-02T08:27:52.557Z","split_payments":null,"frm_metadata":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null}
  • Complete the transaction
  • Retrieve payment to get the payment_method_id

cURL

curl --location --request GET 'http://localhost:8080/payments/pay_lVqK4xVFlhPsDKVArnIo?force_sync=true' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_rh7Gdbe4bpB4Vxz9A7SQge8NwmI48LHgckedcW181ltQ5xJte0ADtOBsW7tmQaI0'

Response

{"payment_id":"pay_lVqK4xVFlhPsDKVArnIo","merchant_id":"merchant_1735800357","status":"succeeded","amount":100,"net_amount":100,"shipping_cost":null,"amount_capturable":0,"amount_received":100,"connector":"adyen","client_secret":"pay_lVqK4xVFlhPsDKVArnIo_secret_jge63cwkJDCY1FZMzOeR","created":"2025-01-02T08:27:51.185Z","currency":"USD","customer_id":"cus_VzApV1FxWKoB90X5uEcm","customer":{"id":"cus_VzApV1FxWKoB90X5uEcm","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+65"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":"off_session","off_session":null,"capture_on":null,"capture_method":"automatic","payment_method":"card","payment_method_data":{"card":{"last4":"5454","card_type":"CREDIT","card_network":"Mastercard","card_issuer":"BANKHANDLOWYWWARSZAWIE.S.A.","card_issuing_country":"POLAND","card_isin":"545454","card_extended_bin":null,"card_exp_month":"03","card_exp_year":"2030","card_holder_name":"John US","payment_checks":null,"authentication_data":null},"billing":{"address":{"city":null,"country":null,"line1":null,"line2":null,"line3":null,"zip":null,"state":null,"first_name":"John","last_name":"US"},"phone":null,"email":"[email protected]"}},"payment_token":null,"shipping":null,"billing":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"John","last_name":"US"},"phone":null,"email":null},"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://hyperswitch.io/","authentication_type":"no_three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":null,"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"credit","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":null,"manual_retry_allowed":false,"connector_transaction_id":"Z3S5HHVH5S5H3275","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":"pay_lVqK4xVFlhPsDKVArnIo_1","payment_link":null,"profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_Vcy2aZeTpgwfuzHd79R3","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-01-02T08:42:51.185Z","fingerprint":null,"browser_info":{"language":"en-US","time_zone":-330,"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","color_depth":32,"java_enabled":true,"screen_width":1728,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":1117,"java_script_enabled":true},"payment_method_id":"pm_MO7c0p19Rgc2p6nDSWCd","payment_method_status":"active","updated":"2025-01-02T08:29:21.898Z","split_payments":null,"frm_metadata":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null}
2. [Novalnet] MIT for cards using NTI

cURL

curl --location --request POST 'http://localhost:8080/payments' \
    --header 'Content-Type: application/json' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_rh7Gdbe4bpB4Vxz9A7SQge8NwmI48LHgckedcW181ltQ5xJte0ADtOBsW7tmQaI0' \
    --data-raw '{"amount":6500,"currency":"USD","confirm":true,"capture_method":"automatic","capture_on":"2022-09-10T10:11:12Z","customer_id":"cus_VzApV1FxWKoB90X5uEcm","email":"[email protected]","name":"John Doe","phone":"999999999","profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","phone_country_code":"+65","description":"Its my first payment request","authentication_type":"no_three_ds","return_url":"https://hyperswitch.io","off_session":true,"recurring_details":{"type":"payment_method_id","data":"pm_dKKRxNRCIsi84dCE3DCc"},"connector":["novalnet"],"statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","metadata":{"udf1":"value1","new_customer":"true","login_date":"2019-09-10T10:11:12Z"},"browser_info":{"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","language":"en-US","color_depth":32,"screen_height":1117,"screen_width":1728,"time_zone":-330,"java_enabled":true,"java_script_enabled":true}}'

Response

{"payment_id":"pay_3W4Chua2lDw4bYxDaRqt","merchant_id":"merchant_1735800357","status":"succeeded","amount":6500,"net_amount":6500,"shipping_cost":null,"amount_capturable":0,"amount_received":6500,"connector":"novalnet","client_secret":"pay_3W4Chua2lDw4bYxDaRqt_secret_nA6hiXdx8QLwjt71ffOd","created":"2025-01-02T08:32:03.307Z","currency":"USD","customer_id":"cus_VzApV1FxWKoB90X5uEcm","customer":{"id":"cus_VzApV1FxWKoB90X5uEcm","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+65"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":null,"off_session":true,"capture_on":null,"capture_method":"automatic","payment_method":"card","payment_method_data":{"card":{"last4":"5454","card_type":"CREDIT","card_network":"Mastercard","card_issuer":"BANKHANDLOWYWWARSZAWIE.S.A.","card_issuing_country":"POLAND","card_isin":"545454","card_extended_bin":null,"card_exp_month":"03","card_exp_year":"2030","card_holder_name":"John US","payment_checks":null,"authentication_data":null},"billing":null},"payment_token":null,"shipping":null,"billing":null,"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://hyperswitch.io/","authentication_type":"no_three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":null,"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"credit","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"cus_VzApV1FxWKoB90X5uEcm","created_at":1735806723,"expires":1735810323,"secret":"epk_4479174c59444f52816900c1d0a0a602"},"manual_retry_allowed":false,"connector_transaction_id":"15133000040614710","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":"15133000040614710","payment_link":null,"profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_q8uMuxuvlutjsnNPaqEs","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-01-02T08:47:03.307Z","fingerprint":null,"browser_info":{"language":"en-US","time_zone":-330,"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","color_depth":32,"java_enabled":true,"screen_width":1728,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":1117,"java_script_enabled":true},"payment_method_id":"pm_dKKRxNRCIsi84dCE3DCc","payment_method_status":"active","updated":"2025-01-02T08:32:07.974Z","split_payments":null,"frm_metadata":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null}
3. [Worldpay] MIT for cards using NTI

cURL

curl --location --request POST 'http://localhost:8080/payments' \
    --header 'Content-Type: application/json' \
    --header 'Accept: application/json' \
    --header 'api-key: dev_rh7Gdbe4bpB4Vxz9A7SQge8NwmI48LHgckedcW181ltQ5xJte0ADtOBsW7tmQaI0' \
    --data-raw '{"amount":6500,"currency":"USD","confirm":true,"capture_method":"automatic","capture_on":"2022-09-10T10:11:12Z","customer_id":"cus_VzApV1FxWKoB90X5uEcm","email":"[email protected]","name":"John Doe","phone":"999999999","profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","phone_country_code":"+65","description":"Its my first payment request","authentication_type":"no_three_ds","return_url":"https://hyperswitch.io","off_session":true,"recurring_details":{"type":"payment_method_id","data":"pm_dKKRxNRCIsi84dCE3DCc"},"connector":["worldpay"],"statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","metadata":{"udf1":"value1","new_customer":"true","login_date":"2019-09-10T10:11:12Z"},"browser_info":{"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","language":"en-US","color_depth":32,"screen_height":1117,"screen_width":1728,"time_zone":-330,"java_enabled":true,"java_script_enabled":true}}'

Response

{"payment_id":"pay_rzcivnTTSrT8D2doTu8S","merchant_id":"merchant_1735800357","status":"succeeded","amount":6500,"net_amount":6500,"shipping_cost":null,"amount_capturable":0,"amount_received":6500,"connector":"worldpay","client_secret":"pay_rzcivnTTSrT8D2doTu8S_secret_nFPSG4JuDSZRr6iYV7sk","created":"2025-01-02T08:30:36.855Z","currency":"USD","customer_id":"cus_VzApV1FxWKoB90X5uEcm","customer":{"id":"cus_VzApV1FxWKoB90X5uEcm","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+65"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":null,"off_session":true,"capture_on":null,"capture_method":"automatic","payment_method":"card","payment_method_data":{"card":{"last4":"5454","card_type":"CREDIT","card_network":"Mastercard","card_issuer":"BANKHANDLOWYWWARSZAWIE.S.A.","card_issuing_country":"POLAND","card_isin":"545454","card_extended_bin":null,"card_exp_month":"03","card_exp_year":"2030","card_holder_name":"John US","payment_checks":null,"authentication_data":null},"billing":null},"payment_token":null,"shipping":null,"billing":null,"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://hyperswitch.io/","authentication_type":"no_three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":null,"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"credit","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"cus_VzApV1FxWKoB90X5uEcm","created_at":1735806636,"expires":1735810236,"secret":"epk_f8f4d087bc4148f98b3b0ba8e81e22b3"},"manual_retry_allowed":false,"connector_transaction_id":"eyJrIjoiazNhYjYzMiIsImxpbmtWZXJzaW9uIjoiNS4wLjAifQ==.sN:g8wd64bwkbrp0md+bPxcanBnk2zLdsIqSa1pR99GGg8fCNQpPLoWNslSzWNPFBM5Tpa8tW7EFI5onKINsgChMHeJVoeH2lrBWCRyjZYT6h+lbqfJa+1BSoKFSY8HLiz6vUTzxKAX24Ht8ZQ4HMhu9ADJnDtIHgxF9tK1ofAqmfgF9Uk2Www3mSVoKRxeIXIe9pic4l22Rveu3MW0qp:7+4GYJYOg3e9WdLnxDKf8zDOVuNV9Smp3TrKAPuNF+l9HY8h4r+1y1WBHupQz59qPpv59wMMnZCI15w9voaKGUgn8jvCNhmdUlN6uDEfAu3+Gpx8cadeYO0VLI6Wl9IpfjEUa63t7mpDaTErQBefTyL+3aw0lAN5HuRY6n0Lw81eWY3h7IW9jcvHhnfJ6QTQ==","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":"4af31547-85c9-4413-93e6-67917d09db32","payment_link":null,"profile_id":"pro_lNLLS8WnmDP5uYTJQpIE","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_9i9j8AIAxASZwPltj1ED","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-01-02T08:45:36.855Z","fingerprint":null,"browser_info":{"language":"en-US","time_zone":-330,"ip_address":"129.0.0.1","user_agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36","color_depth":32,"java_enabled":true,"screen_width":1728,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":1117,"java_script_enabled":true},"payment_method_id":"pm_dKKRxNRCIsi84dCE3DCc","payment_method_status":"active","updated":"2025-01-02T08:30:38.635Z","split_payments":null,"frm_metadata":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null}
4. Ran cypress test cases for Worldpay Screenshot 2025-01-16 at 12 09 21 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m requested review from a team as code owners December 26, 2024 11:38
@kashif-m kashif-m linked an issue Dec 26, 2024 that may be closed by this pull request
2 tasks
AkshayaFoiger
AkshayaFoiger previously approved these changes Jan 2, 2025
@kashif-m kashif-m self-assigned this Jan 2, 2025
@kashif-m kashif-m added the A-connector-integration Area: Connector integration label Jan 2, 2025
cookieg13
cookieg13 previously approved these changes Jan 2, 2025
dracarys18
dracarys18 previously approved these changes Jan 3, 2025
AkshayaFoiger
AkshayaFoiger previously approved these changes Jan 10, 2025
dracarys18
dracarys18 previously approved these changes Jan 10, 2025
@kashif-m kashif-m dismissed stale reviews from dracarys18 and AkshayaFoiger via f8517e4 January 13, 2025 08:41
AkshayaFoiger
AkshayaFoiger previously approved these changes Jan 13, 2025
dracarys18
dracarys18 previously approved these changes Jan 13, 2025
@likhinbopanna
Copy link
Contributor

@kashif-m Can we changes in cypress also ?

cookieg13
cookieg13 previously approved these changes Jan 15, 2025
@kashif-m kashif-m changed the title feat(connectors): fiuu,novalnet,worldpay - extend NTI flows feat(connectors): novalnet,worldpay - extend NTI flows Jan 15, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@kashif-m kashif-m dismissed stale reviews from cookieg13, dracarys18, and AkshayaFoiger via f43fd4f January 15, 2025 18:44
@kashif-m kashif-m requested a review from a team as a code owner January 15, 2025 18:44
@kashif-m kashif-m changed the title feat(connectors): novalnet,worldpay - extend NTI flows feat(connectors): fiuu,novalnet,worldpay - extend NTI flows Jan 15, 2025
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress changes lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] integrate NTI flow for Worldpay and Novalnet
7 participants