-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connectors): fiuu,novalnet,worldpay - extend NTI flows #6946
Open
kashif-m
wants to merge
12
commits into
main
Choose a base branch
from
6941-feature-integrate-nti-flow-for-worldpay-and-novalnet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(connectors): fiuu,novalnet,worldpay - extend NTI flows #6946
kashif-m
wants to merge
12
commits into
main
from
6941-feature-integrate-nti-flow-for-worldpay-and-novalnet
+605
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-nti-flow-for-worldpay-and-novalnet
2 tasks
AkshayaFoiger
previously approved these changes
Jan 2, 2025
cookieg13
previously approved these changes
Jan 2, 2025
dracarys18
previously approved these changes
Jan 3, 2025
kashif-m
dismissed stale reviews from dracarys18, cookieg13, and AkshayaFoiger
via
January 10, 2025 09:55
befc6ee
AkshayaFoiger
previously approved these changes
Jan 10, 2025
dracarys18
previously approved these changes
Jan 10, 2025
…e-nti-flow-for-worldpay-and-novalnet
kashif-m
dismissed stale reviews from dracarys18 and AkshayaFoiger
via
January 13, 2025 08:41
f8517e4
AkshayaFoiger
previously approved these changes
Jan 13, 2025
dracarys18
previously approved these changes
Jan 13, 2025
@kashif-m Can we changes in cypress also ? |
cookieg13
previously approved these changes
Jan 15, 2025
kashif-m
changed the title
feat(connectors): fiuu,novalnet,worldpay - extend NTI flows
feat(connectors): novalnet,worldpay - extend NTI flows
Jan 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 15, 2025
kashif-m
dismissed stale reviews from cookieg13, dracarys18, and AkshayaFoiger
via
January 15, 2025 18:44
f43fd4f
kashif-m
changed the title
feat(connectors): novalnet,worldpay - extend NTI flows
feat(connectors): fiuu,novalnet,worldpay - extend NTI flows
Jan 15, 2025
pixincreate
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cypress changes lgtm
srujanchikke
approved these changes
Jan 16, 2025
dracarys18
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Described in #6941
This PR adds NTI flow integrations for below connectors
payment_methods
from connector's PSync responseAdditional Changes
Motivation and Context
How did you test it?
1. CIT for cards through Adyen
cURL
Response
payment_method_id
cURL
Response
2. [Novalnet] MIT for cards using NTI
cURL
Response
3. [Worldpay] MIT for cards using NTI
cURL
Response
4. Ran cypress test cases for Worldpay
Checklist
cargo +nightly fmt --all
cargo clippy