-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schema): add a new column for storing large connector transaction IDs #7017
Open
kashif-m
wants to merge
8
commits into
main
Choose a base branch
from
6316-db-and-dynamic-fields-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor_refund_data columns to 1024 chars
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 9, 2025
kashif-m
added
A-payments
Area: payments
and removed
M-database-changes
Metadata: This PR involves database schema changes
labels
Jan 9, 2025
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 10, 2025
2 tasks
kashif-m
changed the title
refactor(schema): alter type of connector_transaction_data and connector_refund_data columns to 1024 chars
refactor(schema): add a new column for storing large connector transaction IDs
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces below changes around Worldpay connector
Core changes
payment_attempt
-processor_transaction_data
refund
-connector_transaction_data
andconnector_refund_data
captures
-connector_capture_data
Connector integration changes (Worldpay only)
line1
andcity
non optional in payment requestzip
in dynamic required fields for Worldpay cardsQA
Additional Changes
Motivation and Context
This PR keeps Worldpay's payments integration intact.
How did you test it?
1. Route a payment through Worldpay
cURL
Response
2. Create a payment link without passing in details
cURL
3. Dynamic field tests
Checklist
cargo +nightly fmt --all
cargo clippy