Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building on Intel mac and linux system with nixos #103

Closed
wants to merge 2 commits into from
Closed

Allow building on Intel mac and linux system with nixos #103

wants to merge 2 commits into from

Conversation

1vipulgupta
Copy link
Collaborator

@1vipulgupta 1vipulgupta commented Nov 10, 2023 •
edited
Loading

Intel builds were failing with error

Undefined symbols for architecture x86_64:
       >             "_kCFURLVolumeAvailableCapacityForImportantUsageKey", referenced from:

due to missing IOKit dependency for rust

and
nixos build were failing due to missing package pkg-config

@1vipulgupta 1vipulgupta requested a review from srid November 10, 2023 18:03
@1vipulgupta 1vipulgupta changed the title Just watch fix add dependencies to flake and rust Nov 10, 2023
@1vipulgupta 1vipulgupta changed the title add dependencies to flake and rust added dependencies to flake and rust Nov 10, 2023
@1vipulgupta 1vipulgupta changed the title added dependencies to flake and rust Allow building on Intel mac Nov 10, 2023
@1vipulgupta 1vipulgupta changed the title Allow building on Intel mac Allow building on Intel mac and linux system with nixos Nov 10, 2023
srid
srid reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.

rust.nix
Comment on lines 18 to +19
IOKit
pkgs.darwin.apple_sdk_11_0.frameworks.IOKit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two IOKit's ... shouldn't you remove one of them?

@srid srid marked this pull request as draft November 13, 2023 14:07
@srid
Copy link
Member

srid commented Nov 13, 2023 •
edited
Loading

nixos build were failing due to missing package pkg-config

What's the error you see? Because nix build works fine for me on NixOS.

EDIT: Did you mean #100?

@srid
Copy link
Member

srid commented Dec 18, 2023

The NixOS issue should be fixed in 3ca8f2d

@1vipulgupta I'm closing this in favour of #109.

@srid srid closed this Dec 18, 2023
@srid srid deleted the just-watch-fix branch December 18, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1vipulgupta @srid