Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): Separate jobs into individual files #203

Closed
wants to merge 16 commits into from

Conversation

shivaraj-bh
Copy link
Member

No description provided.

@shivaraj-bh
Copy link
Member Author

@shivaraj-bh
Copy link
Member Author

@srid what is the "Actions permissions” in the settings?

@srid
Copy link
Member

srid commented Aug 6, 2024

You are referring to this?

image

It is already enabled:

image

@srid
Copy link
Member

srid commented Aug 7, 2024

@shivaraj-bh You can use the gh cli to view more diagnostic info.

Running gh run view --job 28475395098 produces:


X breakdown-ci CI juspay/nix-browser#203 · 10288826942
Triggered via pull_request about 10 minutes ago

X trigger-static-binary-check in 5s (ID 28475395098)
  ✓ Set up job
  ✓ Run actions/checkout@v4
  X Run static binary workflow
  ✓ Post Run actions/checkout@v4
  ✓ Complete job

ANNOTATIONS
X /home/runner/work/omnix/omnix/./.github/workflows/static-binary-check/action.yaml (Line: 7, Col: 14): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.system
trigger-static-binary-check: .github#1

X /home/runner/work/omnix/omnix/./.github/workflows/static-binary-check/action.yaml (Line: 15, Col: 17): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.system == 'ubuntu-latest' && 'x86_64-linux' || matrix.system == 'macos-latest' && 'aarch64-darwin' || matrix.system
trigger-static-binary-check: .github#2

X Failed to load /home/runner/work/omnix/omnix/./.github/workflows/static-binary-check/action.yaml
trigger-static-binary-check: .github#3


To see the logs for the failed steps, try: gh run view --log-failed --job=28475395098
View this run on GitHub: https://github.com/juspay/omnix/actions/runs/10288826942

@shivaraj-bh
Copy link
Member Author

I can’t use matrix inside a reusable workflow, but apparently I can do https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow, but that failed as well: https://github.com/juspay/omnix/actions/runs/10288994469/job/28475862141. The linked action runs d1608c6

@srid
Copy link
Member

srid commented Aug 7, 2024

Do we need matrix builds for static-binary-check at all?

I'd imagine you can put runs-on name (eg: ubuntu-latest) as part of the uploaded artifact; and the consuming workflow can then just directly use that in its runs-on?

@srid
Copy link
Member

srid commented Aug 7, 2024

Anyway, let's not worry too much about doing this (especially as #199 should simplify our workflow).

At one point, I'm thinking we could just generate the singular workflow YAML from some saner DSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants