fix: Handle base="/" correctly in GraphView URL construction #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2025 14:24
## Features - Add rehype-slug and rehype-autolink-headings to astro-spaceship - Configure anchor links with link icon (instead of # symbol) - Style anchor links to appear on hover with smooth fade transition - Links use currentColor for proper theme integration ## Bug Fixes - Add missing hast-util-from-html and hast-util-to-html dependencies to astro-loader-obsidian - These were already imported in obsidianEmbeds.ts but not declared in package.json - Required for Obsidian embed feature (![[note]] syntax) - Add docs folder to pnpm workspace for proper local package linking ## Implementation - Anchor links append a link icon SVG to headings (h1-h6) - Icon inherits heading color and is hidden by default - Visible on heading hover for better UX - Creates shareable section URLs with hash anchors
Fixes graph loading issue when SPACESHIP_BASE is set to "/". The previous implementation created invalid URLs with triple slashes (///_spaceship/...) when the base path was root. Now properly normalizes the base path before constructing URLs. Fixes aitorllj93#24
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
GraphView.astroto normalize the base path before URL constructionRelated Issue
Fixes aitorllj93/astro-theme-spaceship#24