initial setup of bazel toolchain for qt #28
Conversation
The goal is to separate rule implementations from the platform-specific binaries and settings needed. To start, the toolchain provides hard-coded paths to the moc, rcc, and uic tools. tools/BUILD provides separate values for Windows and Linux. The next step, I think, is to use qt_configure.bzl to dynamically determine the paths to these tools on the current system.
|
@limdor, let me know if you have any thoughts on this, I know you've spent some time looking into bazel toolchains. I tried locally merging these changes into #23 and with some minor changes to |
There was a problem hiding this comment.
@justbuchanan I just added some comments based on some of the thinking that I did on toolchains. I added some links that can also help you to see what ideas I had in mind.
In addition I created a draft PR with what I had in progress, it was not much but was just to show the approach that I was taking and in the end is very similar to what you are doing here.
#29
I would be interested on knowing how you solved locally the problem with the ui rule, the problem is that ui is quite picky on the path inside the ui files and how this relates to the working directory and to the ui location.
Also some of the initials ideas I was discussing them with @aiuto in this thread:
https://groups.google.com/g/bazel-dev/c/Y8LOU-CxZkw/m/4zlmpGUKBQAJ
| @@ -11,3 +12,5 @@ new_local_repository( | |||
| build_file = "@com_justbuchanan_rules_qt//:qt.BUILD", | |||
| path = local_qt_path(), | |||
| ) | |||
|
|
|||
| register_qt_toolchains() | |||
There was a problem hiding this comment.
My idea regarding qt_configure and register_qt_toolchains was that in the future both are merged in one single call and you only need to call register_qt_toolchain. One option to do that is with template files, similar to what is done in rules_go https://github.com/bazelbuild/rules_go/blob/4cd45a2ac59bd00ba54d23ebbdb7e5e2aed69007/go/private/sdk.bzl
There was a problem hiding this comment.
Sounds good, I agree it would be best to put everything in just a single function that needs to be called from WORKSPACE. I'll look at refactoring this to do so.
|
Here's the change to |
Interesting that with this works, not sure if the working directory then with toolchains is different. Anyway, cool that works! |
The goal is to separate rule implementations from the platform-specific
binaries and settings needed. To start, the toolchain provides
hard-coded paths to the moc, rcc, and uic tools. tools/BUILD provides
separate values for Windows and Linux.
The next step, I think, is to use qt_configure.bzl to dynamically
determine the paths to these tools on the current system.
Bazel docs on toolchains: https://docs.bazel.build/versions/master/toolchains.html.