v10.0.0 – Updating gulp-build-fozzie to use gulp v4 (#165)

.github/CODEOWNERS

@@ -8,8 +8,4 @@
 
 
 # These owners will be the default owners for everything in the repo.
-*            @justeat/ui-admins
-
-# When someone opens a pull request that only modifies JS unit test files
-# Disabled for now to prevent blocking the merging of PRs if owner is not available.
-#*.test.js    @damianmullins
+* @justeat/ui-senior-reviewers-web @justeat/ui-reviewers-web

CHANGELOG.md

@@ -4,6 +4,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 
+v10.0.0
+------------------------------
+*March 6, 2020*
+
+## Changed
+- Upgrade `gulp` to v4 (so that it's now compatible with Node v12)
+
+
 v9.1.0
 ------------------------------
 *February 19, 2020*

config.js

@@ -46,7 +46,7 @@ const ConfigOptions = () => {
                 }
             },
             jsDir: 'js',
-            lintPaths: [''],
+            lintPaths: [],
             usePackageVersion: false,
             stripDebug
         },

package.json

@@ -1,11 +1,12 @@
 {
   "name": "@justeat/gulp-build-fozzie",
-  "version": "9.1.0",
+  "version": "10.0.0",
   "description": "Gulp build tasks for use across Fozzie modules",
   "main": "index.js",
-  "author": "Damian Mullins <[email protected]> (http://www.damianmullins.com)",
   "contributors": [
-    "Github contributors <https://github.com/justeat/gulp-build-fozzie/graphs/contributors>"
+    "Ashley Nolan <[email protected]> (https://ashleynolan.co.uk)",
+    "Damian Mullins <[email protected]> (http://www.damianmullins.com)",
+    "Github contributors <https://github.com/justeat/fozzie/graphs/contributors>"
   ],
   "license": "Apache-2.0",
   "repository": {
@@ -28,8 +29,8 @@
   },
   "dependencies": {
     "@babel/cli": "7.8.4",
-    "@babel/core": "7.8.4",
-    "@babel/preset-env": "7.8.4",
+    "@babel/core": "7.8.7",
+    "@babel/preset-env": "7.8.7",
     "@justeat/eslint-config-fozzie": "3.4.0",
     "@justeat/f-copy-assets": "1.1.0",
     "@justeat/f-templates-loader": "0.1.1",
@@ -41,52 +42,52 @@
     "browser-sync": "2.26.7",
     "browserify": "16.5.0",
     "cssnano": "4.1.10",
-    "del": "3.0.0",
+    "del": "5.1.0",
     "eslint": "6.8.0",
     "eslint-plugin-import": "2.20.1",
-    "event-stream": "3.3.4",
+    "event-stream": "4.0.1",
     "exorcist": "1.0.1",
     "eyeglass": "1.4.1",
     "filesizegzip": "2.0.0",
-    "gulp": "3.9.1",
+    "gulp": "4.0.2",
     "gulp-cached": "1.1.1",
-    "gulp-changed": "3.2.0",
+    "gulp-changed": "4.0.2",
     "gulp-clone": "2.0.1",
     "gulp-eslint": "6.0.0",
     "gulp-extname": "0.2.2",
     "gulp-file": "0.4.0",
     "gulp-filenames": "4.0.1",
     "gulp-if": "3.0.0",
-    "gulp-imagemin": "4.1.0",
+    "gulp-imagemin": "7.1.0",
     "gulp-newer": "1.4.0",
     "gulp-plumber": "1.2.1",
     "gulp-postcss": "8.0.0",
-    "gulp-rename": "1.4.0",
-    "gulp-rev": "8.1.1",
+    "gulp-rename": "2.0.0",
+    "gulp-rev": "9.0.0",
     "gulp-sass": "4.0.2",
     "gulp-sass-variables": "1.2.0",
     "gulp-size": "3.0.0",
     "gulp-sourcemaps": "2.6.5",
     "gulp-strip-debug": "3.0.0",
-    "gulp-stylelint": "8.0.0",
-    "gulp-svgmin": "1.2.4",
+    "gulp-stylelint": "13.0.0",
+    "gulp-svgmin": "2.2.0",
     "gulp-svgstore": "7.0.1",
-    "gulp-tap": "1.0.1",
-    "gulp-uglify-es": "1.0.4",
+    "gulp-tap": "2.0.0",
+    "gulp-uglify-es": "2.0.0",
     "gulp-util": "3.0.8",
     "handlebars-helper-i18n": "0.1.0",
     "handlebars-helpers": "0.10.0",
     "helper-markdown": "1.0.0",
     "helper-md": "0.2.2",
     "jest": "25.1.0",
     "lodash.union": "4.6.0",
-    "merge-stream": "1.0.1",
+    "merge-stream": "2.0.0",
     "postcss-assets": "5.0.0",
     "postcss-reporter": "6.0.1",
     "require-dir": "1.2.0",
     "run-sequence": "2.2.1",
-    "stylelint": "9.8.0",
-    "stylelint-scss": "3.4.0",
+    "stylelint": "13.2.0",
+    "stylelint-scss": "3.14.2",
     "sw-precache": "5.2.1",
     "vinyl-buffer": "1.0.1",
     "vinyl-source-stream": "2.0.0"
@@ -102,6 +103,6 @@
     "babel-core": "7.0.0-bridge.0"
   },
   "peerDependencies": {
-    "gulp": "3.9.1"
+    "gulp": "4.0.2"
   }
 }

tasks-dev/browser-sync.js

@@ -11,7 +11,7 @@ const pathBuilder = require('../pathBuilder');
  * Watches for changes to files and reloads a local website instance.
  *
  */
-gulp.task('browser-sync', ['watch'], () => {
+gulp.task('browser-sync', gulp.series('watch', () => {
     const options = {
         files: [
             `./${pathBuilder.cssDistDir}/**/*.css`,
@@ -23,7 +23,7 @@ gulp.task('browser-sync', ['watch'], () => {
     };
 
     browserSync.init(options);
-});
+}));
 
 
 /**
@@ -32,7 +32,7 @@ gulp.task('browser-sync', ['watch'], () => {
  * Generates the documentation files then opens the docs in a local server.
  *
  */
-gulp.task('browser-sync:docs', ['assemble'], () => {
+gulp.task('browser-sync:docs', gulp.series('assemble', () => {
     // TODO : SORT OUT PATHS AS NOT WORKING ON INTERNATIONAL CONSUMERWEB PROPERLY
     const options = {
         files: [
@@ -50,4 +50,4 @@ gulp.task('browser-sync:docs', ['assemble'], () => {
     };
 
     browserSync.init(options);
-});
+}));

test/config.test.js

@@ -219,7 +219,7 @@ describe('javascript config', () => {
     });
 
     it('`lintPaths` should be set', () => {
-        expect(config.js.lintPaths).toEqual(['']);
+        expect(config.js.lintPaths).toEqual([]);
     });
 
     it('`lintPaths` can be updated', () => {