Update to .NET 8 #1162

martincostello · 2023-05-04T10:29:12Z

Update to .NET 8.
Remove redundant --configuration Release.
Use new artifacts output.

codecov · 2023-05-16T17:59:39Z

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (af15259) 79.30% compared to head (5b0c04c) 78.96%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...rc/JustSaying/Messaging/Monitoring/LogOperation.cs	61.53%	4 Missing and 1 partial ⚠️
...tSaying/AwsTools/MessageHandling/SnsTopicByName.cs	73.33%	3 Missing and 1 partial ⚠️
...t/ServiceResolver/ServiceBuilderServiceResolver.cs	69.23%	2 Missing and 2 partials ⚠️
.../Messaging/Middleware/Backoff/BackoffMiddleware.cs	25.00%	0 Missing and 3 partials ⚠️
...wsTools/MessageHandling/ForeignTopicArnProvider.cs	0.00%	2 Missing ⚠️
.../SubscriptionGroups/SubscriptionGroupCollection.cs	66.66%	0 Missing and 2 partials ⚠️
...ng/Middleware/ExactlyOnce/ExactlyOnceMiddleware.cs	83.33%	2 Missing ⚠️
.../AwsTools/MessageHandling/LocalTopicArnProvider.cs	0.00%	1 Missing ⚠️
...ing/AwsTools/MessageHandling/SqsQueueByNameBase.cs	85.71%	1 Missing ⚠️
...JustSaying/Fluent/MessagingConfigurationBuilder.cs	0.00%	1 Missing ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   79.30%   78.96%   -0.35%     
==========================================
  Files         138      138              
  Lines        3330     3232      -98     
  Branches      453      451       -2     
==========================================
- Hits         2641     2552      -89     
+ Misses        454      449       -5     
+ Partials      235      231       -4

Flag	Coverage Δ
linux	`78.96% <85.96%> (-0.35%)`	⬇️
macos	`48.96% <64.56%> (-0.66%)`	⬇️
windows	`49.40% <65.26%> (-0.21%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cherry-pick various changes from justeattakeaway#1162.

Cherry-pick various changes from #1162.

.github/workflows/update-dotnet-sdk.yml

The Microsoft.SourceLink.GitHub package is now added automatically by the .NET SDK.

* Update .NET SDK Update .NET SDK to version 8.0.100-preview.6.23330.14. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.6.23330.14 SDK. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. Bumps Microsoft.Extensions.Configuration.Json from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. Bumps Microsoft.Extensions.DependencyInjection from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. Bumps Microsoft.Extensions.DependencyInjection.Abstractions from 1.1.0 to 1.1.1. Bumps Microsoft.Extensions.Hosting from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. Bumps Microsoft.Extensions.Logging from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. Bumps Microsoft.Extensions.Logging.Abstractions from 2.0.0 to 2.2.0. Bumps Microsoft.Extensions.Logging.Console from 8.0.0-preview.5.23280.8 to 8.0.0-preview.6.23329.7. --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection.Abstractions dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.Hosting dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> * Revert baseline versions Undo package updates to baseline packages. --------- Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <[email protected]>

Update .NET SDK to version 8.0.100-preview.7.23376.3. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Bumps .NET dependencies to their latest versions for the .NET 8.0.100-preview.7.23376.3 SDK. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. Bumps Microsoft.Extensions.Configuration.Json from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. Bumps Microsoft.Extensions.DependencyInjection from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. Bumps Microsoft.Extensions.Hosting from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. Bumps Microsoft.Extensions.Logging from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. Bumps Microsoft.Extensions.Logging.Console from 8.0.0-preview.6.23329.7 to 8.0.0-preview.7.23375.6. --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Hosting dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Update .NET SDK to version 8.0.100-rc.1.23455.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Update .NET SDK to version 8.0.100-rc.1.23463.5. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Update NuGet packages for RC1.

- Set SuppressTfmSupportBuildWarnings to silence warning for `net461`. - Remove redundant references. - Fix-up indentation.

- Use primary constructors where relevant. - Use collection literals where relevant. - Adopt various IDE suggestions. - Fix typos. - Remove redundant suppressions. _ Skip test locally that needs AWS. - Fix new code analysis warnings/suggestions.

* Update .NET SDK Update .NET SDK to version 8.0.100-rc.2.23502.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100-rc.2.23502.2 SDK. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. Bumps Microsoft.Extensions.Configuration.Json from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. Bumps Microsoft.Extensions.DependencyInjection from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. Bumps Microsoft.Extensions.Hosting from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. Bumps Microsoft.Extensions.Logging from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. Bumps Microsoft.Extensions.Logging.Console from 8.0.0-rc.1.23419.4 to 8.0.0-rc.2.23479.6. --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Hosting dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> --------- Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Use the new MSBuild terminal logger.

* Update .NET SDK Update .NET SDK to version 8.0.100. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 8.0.100 SDK. Bumps Microsoft.Extensions.Configuration.EnvironmentVariables from 8.0.0-rc.2.23479.6 to 8.0.0. Bumps Microsoft.Extensions.Configuration.Json from 8.0.0-rc.2.23479.6 to 8.0.0. Bumps Microsoft.Extensions.DependencyInjection from 8.0.0-rc.2.23479.6 to 8.0.0. Bumps Microsoft.Extensions.Hosting from 8.0.0-rc.2.23479.6 to 8.0.0. Bumps Microsoft.Extensions.Logging from 8.0.0-rc.2.23479.6 to 8.0.0. Bumps Microsoft.Extensions.Logging.Console from 8.0.0-rc.2.23479.6 to 8.0.0. --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.EnvironmentVariables dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Configuration.Json dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.DependencyInjection dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Hosting dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.Extensions.Logging.Console dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> --------- Signed-off-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com> Co-authored-by: jet-codeflow-maintainer[bot] <131594757+jet-codeflow-maintainer[bot]@users.noreply.github.com>

Update Serilog.Extensions.Logging to 8.0.0.

martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels May 4, 2023

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from d81609f to 16766dd Compare May 17, 2023 09:09

martincostello added a commit to martincostello/JustSaying that referenced this pull request May 18, 2023

.NET 8 preparation

900c16c

Cherry-pick various changes from justeattakeaway#1162.

martincostello mentioned this pull request May 18, 2023

.NET 8 preparation #1173

Merged

martincostello added a commit that referenced this pull request May 18, 2023

.NET 8 preparation

7921e39

Cherry-pick various changes from #1162.

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 23b8361 to 2e59499 Compare May 22, 2023 13:14

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from e514a5f to 79ce1ea Compare June 20, 2023 09:49

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from 8d008ed to 95251bc Compare June 23, 2023 10:44

martincostello force-pushed the dotnet-vnext branch from 95251bc to 153646e Compare June 30, 2023 08:50

martincostello force-pushed the dotnet-vnext branch from 0881a32 to a9db0a7 Compare July 11, 2023 19:00

martincostello commented Jul 12, 2023

View reviewed changes

.github/workflows/update-dotnet-sdk.yml Outdated Show resolved Hide resolved

martincostello force-pushed the dotnet-vnext branch from 078b816 to 757bfce Compare July 13, 2023 14:35

martincostello force-pushed the dotnet-vnext branch from 757bfce to fc5d682 Compare July 21, 2023 16:26

martincostello mentioned this pull request Jul 21, 2023

Exclude some packages from updates #1217

Merged

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from e0becc5 to 6bae3e4 Compare August 8, 2023 17:12

martincostello force-pushed the dotnet-vnext branch from 6bae3e4 to 2da017b Compare August 17, 2023 09:27

martincostello force-pushed the dotnet-vnext branch from 2da017b to a790b70 Compare August 30, 2023 13:53

martincostello force-pushed the dotnet-vnext branch 2 times, most recently from bd2ec98 to 43c71b4 Compare September 12, 2023 17:18

martincostello force-pushed the dotnet-vnext branch from adbc6c8 to 7ca064d Compare October 10, 2023 18:40

martincostello force-pushed the dotnet-vnext branch from 7ca064d to a0f0c1b Compare October 24, 2023 16:52

martincostello force-pushed the dotnet-vnext branch from a0f0c1b to 59b3d02 Compare November 4, 2023 11:17

martincostello and others added 11 commits November 9, 2023 07:06

Remove Microsoft.SourceLink.GitHub

18b78db

The Microsoft.SourceLink.GitHub package is now added automatically by the .NET SDK.

Update NuGet packages

49119f4

Update NuGet packages for RC1.

Suppress build warning

0236fac

- Set SuppressTfmSupportBuildWarnings to silence warning for `net461`. - Remove redundant references. - Fix-up indentation.

Use new C# language features

75c4c88

- Use primary constructors where relevant. - Use collection literals where relevant. - Adopt various IDE suggestions. - Fix typos. - Remove redundant suppressions. _ Skip test locally that needs AWS. - Fix new code analysis warnings/suggestions.

Use terminal logger

070d404

Use the new MSBuild terminal logger.

martincostello force-pushed the dotnet-vnext branch from 8b62c42 to 070d404 Compare November 9, 2023 07:06

martincostello marked this pull request as ready for review November 14, 2023 16:35

martincostello requested a review from a team as a code owner November 14, 2023 16:35

martincostello enabled auto-merge (squash) November 14, 2023 16:36

This was referenced Nov 14, 2023

Update .NET SDK to 7.0.404 #1280

Closed

Update .NET SDK to 7.0.404 #1281

Closed

Merge branch 'main' into dotnet-vnext

868f866

Bump Serilog.Extensions.Logging

5b0c04c

Update Serilog.Extensions.Logging to 8.0.0.

martincostello mentioned this pull request Nov 15, 2023

Bump Microsoft.Extensions.Logging from 7.0.0 to 8.0.0 #1288

Closed

slang25 approved these changes Nov 15, 2023

View reviewed changes

martincostello merged commit b97240d into main Nov 15, 2023
13 of 14 checks passed

martincostello deleted the dotnet-vnext branch November 15, 2023 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to .NET 8 #1162

Update to .NET 8 #1162

martincostello commented May 4, 2023 •

edited

Loading

codecov bot commented May 16, 2023 •

edited

Loading

Update to .NET 8 #1162

Update to .NET 8 #1162

Conversation

martincostello commented May 4, 2023 • edited Loading

codecov bot commented May 16, 2023 • edited Loading

Codecov Report

martincostello commented May 4, 2023 •

edited

Loading

codecov bot commented May 16, 2023 •

edited

Loading