Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 9 preparation #1466

Merged
merged 1 commit into from
Jul 11, 2024
Merged

.NET 9 preparation #1466

merged 1 commit into from
Jul 11, 2024

Conversation

martincostello
Copy link
Member

  • Move suppressions to .ruleset file.
  • Set NuGetAuditMode=direct.

Cherry-picked from #1358.

- Move suppressions to `.ruleset` file.
- Set `NuGetAuditMode=direct`.
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels Jul 10, 2024
@martincostello martincostello requested a review from a team as a code owner July 10, 2024 16:23
@martincostello martincostello enabled auto-merge (rebase) July 10, 2024 16:24
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (f8e99bc) to head (deb4356).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
+ Coverage   79.22%   79.25%   +0.03%     
==========================================
  Files         138      138              
  Lines        3234     3234              
  Branches      448      448              
==========================================
+ Hits         2562     2563       +1     
+ Misses        441      440       -1     
  Partials      231      231              
Flag Coverage Δ
linux 79.25% <ø> (+0.03%) ⬆️
macos 47.92% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hwoodiwiss
Copy link
Member

The discussion for this CVE indicates that this version is unaffected
GHSA-hh2w-p6rv-4g7w

There's a suggestion to add NoWarn="NU1903" to the package reference to suppress this, which sounds reasonable, at least until the CVE is updated/fixed

@martincostello
Copy link
Member Author

Yeah, I just haven't got around to circling back and fixing this PR yet as I've had a bunch broken this preview.

@martincostello
Copy link
Member Author

I think the GHSA had the wrong versions earlier this week and has since been updated (there was an edit 20 hours ago), as re-running the build with no changes now doesn't raise the warning.

@martincostello martincostello merged commit bd1d3e5 into main Jul 11, 2024
14 checks passed
@martincostello martincostello deleted the dotnet-9-prep branch July 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants