-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show usage of merging snippets into docs #320
Conversation
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 1129 1128 -1
=========================================
- Hits 1129 1128 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This looks cool 👀 I remember way back that I saw the .NET notebook/try.dot.net (or something, I forget) that showed having code samples based on real code that checked it compiled and passed that would have been nice to have. You're right, all the examples in the README are pretty much just taken from the I'll take a proper look at it later today 👍 |
/cc @slang25 - could be good for justeattakeaway/JustSaying#902 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but otherwise this looks great!
tests/HttpClientInterception.Tests/JustEat.HttpClientInterception.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
…ion.Tests.csproj Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Thoughts on making the code snippets in your readme being extracted from real code? I find it makes it easier to maintain docs. Changes in you api are automatically kept in sync and snippets can be taken from tests to ensure those snippet behave as expected
Docs https://github.com/SimonCropp/MarkdownSnippets
I also added a GH Action https://github.com/SimonCropp/MarkdownSnippets/blob/master/docs/github-action.md This can be useful to ensure md docs are in sync when .source files are edited online, and without needing to re-generate the docs locally.