Skip to content

Commit

Permalink
Update button dos and don'ts section
Browse files Browse the repository at this point in the history
  • Loading branch information
@xander-marjoram
xander-marjoram committed Aug 28, 2024
1 parent 6fc6bd4 commit dfab789
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 49 deletions.
8 changes: 4 additions & 4 deletions apps/pie-docs/src/components/button/overview/overview.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ Buttons serve a wide range of purposes in user interfaces, such as submitting fo
do: {
type: usageTypes.text,
items: [
"Use Buttons when you need to direct the user to an action.",
"When pairing Buttons, use the same sized Buttons together."

"Use buttons when you need to direct the user to an action.",
"When pairing buttons, use the same sized buttons together.",
"When multiple buttons are used within the same component or page, ensure that there is a clear hierarchy of actions."
]
},
dont: {
type: usageTypes.text,
items: [
"Only include one primary button in a page or area of UI."
"Don't mix button sizes when buttons are used together in a pair."
]
}
} %}
Expand Down
90 changes: 45 additions & 45 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5459,7 +5459,7 @@ __metadata:
resolution: "@justeattakeaway/pie-assistive-text@workspace:packages/components/pie-assistive-text"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5472,7 +5472,7 @@ __metadata:
resolution: "@justeattakeaway/pie-button@workspace:packages/components/pie-button"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-spinner": 0.6.7
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5487,46 +5487,46 @@ __metadata:
resolution: "@justeattakeaway/pie-card@workspace:packages/components/pie-card"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc-core": 0.24.0
"@justeattakeaway/pie-wrapper-react": 0.14.1
cem-plugin-module-file-extensions: 0.0.5
languageName: unknown
linkType: soft

"@justeattakeaway/[email protected].1, @justeattakeaway/pie-checkbox-group@workspace:packages/components/pie-checkbox-group":
"@justeattakeaway/[email protected].2, @justeattakeaway/pie-checkbox-group@workspace:packages/components/pie-checkbox-group":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-checkbox-group@workspace:packages/components/pie-checkbox-group"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-assistive-text": 0.7.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc-core": 0.24.0
cem-plugin-module-file-extensions: 0.0.5
languageName: unknown
linkType: soft

"@justeattakeaway/[email protected].1, @justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox":
"@justeattakeaway/[email protected].2, @justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-assistive-text": 0.7.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc-core": 0.24.0
cem-plugin-module-file-extensions: 0.0.5
languageName: unknown
linkType: soft

"@justeattakeaway/pie-chip@0.7.2, @justeattakeaway/pie-chip@workspace:packages/components/pie-chip":
"@justeattakeaway/pie-chip@0.8.0, @justeattakeaway/pie-chip@workspace:packages/components/pie-chip":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-chip@workspace:packages/components/pie-chip"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-spinner": 0.6.7
Expand All @@ -5535,7 +5535,7 @@ __metadata:
languageName: unknown
linkType: soft

"@justeattakeaway/pie-components-config@0.17.0, @justeattakeaway/pie-components-config@workspace:configs/pie-components-config":
"@justeattakeaway/pie-components-config@0.18.0, @justeattakeaway/pie-components-config@workspace:configs/pie-components-config":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-components-config@workspace:configs/pie-components-config"
dependencies:
Expand All @@ -5554,7 +5554,7 @@ __metadata:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeat/pie-design-tokens": 6.3.1
"@justeattakeaway/pie-button": 0.48.1
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-divider": 0.13.9
"@justeattakeaway/pie-icon-button": 0.28.10
Expand Down Expand Up @@ -5584,7 +5584,7 @@ __metadata:
resolution: "@justeattakeaway/pie-divider@workspace:packages/components/pie-divider"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc-core": 0.24.0
"@justeattakeaway/pie-wrapper-react": 0.14.1
Expand All @@ -5597,7 +5597,7 @@ __metadata:
resolution: "@justeattakeaway/pie-form-label@workspace:packages/components/pie-form-label"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-switch": 0.30.0
"@justeattakeaway/pie-text-input": 0.23.4
Expand All @@ -5618,7 +5618,7 @@ __metadata:
resolution: "@justeattakeaway/pie-icon-button@workspace:packages/components/pie-icon-button"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-spinner": 0.6.7
Expand Down Expand Up @@ -5680,7 +5680,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-icons-webc@workspace:packages/tools/pie-icons-webc"
dependencies:
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-icons": 4.19.0
"@justeattakeaway/pie-icons-configs": 4.5.1
"@justeattakeaway/pie-webc-core": 0.24.0
Expand Down Expand Up @@ -5716,7 +5716,7 @@ __metadata:
resolution: "@justeattakeaway/pie-link@workspace:packages/components/pie-link"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5732,7 +5732,7 @@ __metadata:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeat/pie-design-tokens": 6.3.1
"@justeattakeaway/pie-button": 0.48.1
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icon-button": 0.28.10
"@justeattakeaway/pie-icons-webc": 0.25.0
Expand All @@ -5751,7 +5751,7 @@ __metadata:
resolution: "@justeattakeaway/pie-notification@workspace:packages/components/pie-notification"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icon-button": 0.28.10
"@justeattakeaway/pie-icons-webc": 0.25.0
Expand All @@ -5766,7 +5766,7 @@ __metadata:
resolution: "@justeattakeaway/pie-spinner@workspace:packages/components/pie-spinner"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc-core": 0.24.0
"@justeattakeaway/pie-wrapper-react": 0.14.1
Expand All @@ -5779,7 +5779,7 @@ __metadata:
resolution: "@justeattakeaway/pie-switch@workspace:packages/components/pie-switch"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5794,7 +5794,7 @@ __metadata:
resolution: "@justeattakeaway/pie-tag@workspace:packages/components/pie-tag"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5809,7 +5809,7 @@ __metadata:
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-assistive-text": 0.7.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5819,12 +5819,12 @@ __metadata:
languageName: unknown
linkType: soft

"@justeattakeaway/pie-textarea@0.7.0, @justeattakeaway/pie-textarea@workspace:packages/components/pie-textarea":
"@justeattakeaway/pie-textarea@0.8.0, @justeattakeaway/pie-textarea@workspace:packages/components/pie-textarea":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-textarea@workspace:packages/components/pie-textarea"
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-form-label": 0.14.1
"@justeattakeaway/pie-webc-core": 0.24.0
Expand All @@ -5840,7 +5840,7 @@ __metadata:
dependencies:
"@custom-elements-manifest/analyzer": 0.9.0
"@justeattakeaway/pie-button": 0.48.1
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icon-button": 0.28.10
"@justeattakeaway/pie-icons-webc": 0.25.0
Expand All @@ -5853,7 +5853,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-webc-core@workspace:packages/components/pie-webc-core"
dependencies:
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-components-config": 0.18.0
lit: 3.1.3
languageName: unknown
linkType: soft
Expand All @@ -5869,17 +5869,17 @@ __metadata:
languageName: unknown
linkType: soft

"@justeattakeaway/[email protected].24, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
"@justeattakeaway/[email protected].25, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
version: 0.0.0-use.local
resolution: "@justeattakeaway/pie-webc@workspace:packages/components/pie-webc"
dependencies:
"@justeattakeaway/pie-assistive-text": 0.7.0
"@justeattakeaway/pie-button": 0.48.1
"@justeattakeaway/pie-card": 0.19.8
"@justeattakeaway/pie-checkbox": 0.12.1
"@justeattakeaway/pie-checkbox-group": 0.6.1
"@justeattakeaway/pie-chip": 0.7.2
"@justeattakeaway/pie-components-config": 0.17.0
"@justeattakeaway/pie-checkbox": 0.12.2
"@justeattakeaway/pie-checkbox-group": 0.6.2
"@justeattakeaway/pie-chip": 0.8.0
"@justeattakeaway/pie-components-config": 0.18.0
"@justeattakeaway/pie-cookie-banner": 0.25.1
"@justeattakeaway/pie-divider": 0.13.9
"@justeattakeaway/pie-form-label": 0.14.1
Expand All @@ -5891,7 +5891,7 @@ __metadata:
"@justeattakeaway/pie-switch": 0.30.0
"@justeattakeaway/pie-tag": 0.9.9
"@justeattakeaway/pie-text-input": 0.23.4
"@justeattakeaway/pie-textarea": 0.7.0
"@justeattakeaway/pie-textarea": 0.8.0
"@justeattakeaway/pie-toast": 0.3.1
chalk: 5.3.0
bin:
Expand Down Expand Up @@ -26000,9 +26000,9 @@ __metadata:
"@justeattakeaway/pie-assistive-text": 0.7.0
"@justeattakeaway/pie-button": 0.48.1
"@justeattakeaway/pie-card": 0.19.8
"@justeattakeaway/pie-checkbox": 0.12.1
"@justeattakeaway/pie-checkbox-group": 0.6.1
"@justeattakeaway/pie-chip": 0.7.2
"@justeattakeaway/pie-checkbox": 0.12.2
"@justeattakeaway/pie-checkbox-group": 0.6.2
"@justeattakeaway/pie-chip": 0.8.0
"@justeattakeaway/pie-cookie-banner": 0.25.1
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-divider": 0.13.9
Expand All @@ -26017,7 +26017,7 @@ __metadata:
"@justeattakeaway/pie-switch": 0.30.0
"@justeattakeaway/pie-tag": 0.9.9
"@justeattakeaway/pie-text-input": 0.23.4
"@justeattakeaway/pie-textarea": 0.7.0
"@justeattakeaway/pie-textarea": 0.8.0
"@justeattakeaway/pie-toast": 0.3.1
"@storybook/addon-a11y": 8.2.6
"@storybook/addon-designs": 8.0.3
Expand Down Expand Up @@ -33939,7 +33939,7 @@ __metadata:
"@angular/platform-browser-dynamic": 15.2.0
"@angular/router": 15.2.0
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
rxjs: 7.8.0
tslib: 2.3.0
typescript: 4.9.4
Expand All @@ -33956,7 +33956,7 @@ __metadata:
"@babel/preset-env": 7.24.5
"@babel/preset-react": 7.24.1
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@lit/react": 1.0.2
babel-loader: 8
eslint: 8.37.0
Expand All @@ -33973,7 +33973,7 @@ __metadata:
resolution: "wc-next13@workspace:apps/examples/wc-next13"
dependencies:
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@lit-labs/nextjs": 0.2.0
"@lit/react": 1.0.5
"@types/react": 18.3.3
Expand All @@ -33996,7 +33996,7 @@ __metadata:
dependencies:
"@babel/preset-env": 7.24.5
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
babel-loader: 8
core-js: 3.30.0
nuxt: 2.17.0
Expand All @@ -34011,7 +34011,7 @@ __metadata:
resolution: "wc-nuxt3@workspace:apps/examples/wc-nuxt3"
dependencies:
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@types/node": 18
nuxt: 3.4.3
nuxt-ssr-lit: 1.6.5
Expand All @@ -34023,7 +34023,7 @@ __metadata:
resolution: "wc-react17@workspace:apps/examples/wc-react17"
dependencies:
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@lit/react": 1.0.5
"@types/react": ^17.0.2
"@types/react-dom": ^17.0.2
Expand All @@ -34043,7 +34043,7 @@ __metadata:
resolution: "wc-react18@workspace:apps/examples/wc-react18"
dependencies:
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@lit/react": 1.0.5
"@types/react": 18.3.3
"@types/react-dom": 18.3.0
Expand All @@ -34065,7 +34065,7 @@ __metadata:
"@justeat/pie-design-tokens": 6.3.1
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-icons-webc": 0.25.0
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
vite: 4.5.3
languageName: unknown
linkType: soft
Expand All @@ -34075,7 +34075,7 @@ __metadata:
resolution: "wc-vue3@workspace:apps/examples/wc-vue3"
dependencies:
"@justeattakeaway/pie-css": 0.12.1
"@justeattakeaway/pie-webc": 0.5.24
"@justeattakeaway/pie-webc": 0.5.25
"@types/node": 18.15.11
"@vitejs/plugin-vue": 4.0.0
"@vue/tsconfig": 0.1.3
Expand Down

0 comments on commit dfab789

Please sign in to comment.