chore(eslint-config-pie): DSW-000 add rule for consistent type imports #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9eaffb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
apps
tools
components
pie-button
pie-storybook
pie-modal
pie-webc-core
generator-pie-component
pie-divider
pie-form-label
eslint-config-pie
pie-switch
pie-card
pie-notification
pie-spinner
pie-tag
pie-assistive-text
pie-chip
pie-checkbox
pie-checkbox-group
labels
xander-marjoram
commented
Jul 23, 2024
# Conflicts: # apps/pie-storybook/stories/pie-assistive-text.stories.ts # apps/pie-storybook/stories/pie-checkbox-group.stories.ts # apps/pie-storybook/stories/pie-checkbox.stories.ts # apps/pie-storybook/stories/pie-form-label.stories.ts # apps/pie-storybook/stories/pie-icon-button.stories.ts # apps/pie-storybook/stories/pie-lottie-player.stories.ts # apps/pie-storybook/stories/pie-modal.stories.ts # apps/pie-storybook/stories/pie-notification.stories.ts # apps/pie-storybook/stories/pie-spinner.stories.ts # apps/pie-storybook/stories/pie-switch.stories.ts # apps/pie-storybook/stories/pie-textarea.stories.ts # apps/pie-storybook/stories/pie-toast.stories.ts # yarn.lock
# Conflicts: # packages/components/pie-checkbox/test/component/pie-checkbox.spec.ts
xander-marjoram
force-pushed
the
dsw-000-consistent-type-imports
branch
from
aad3e74 to
cc405ce
Compare
# Conflicts: # packages/components/pie-radio/src/defs-react.ts # packages/components/pie-radio/src/index.ts # packages/components/pie-radio/test/component/pie-radio.spec.ts # yarn.lock
# Conflicts: # packages/components/pie-card/src/index.ts # packages/components/pie-cookie-banner/src/index.ts # packages/components/pie-cookie-banner/test/helpers/page-object/pie-cookie-banner.page.ts
xander-marjoram
removed
work-in-progress
kevinrodrigues
previously approved these changes
Oct 1, 2024
xander-marjoram
dismissed stale reviews from kevinrodrigues and raoufswe
via
ca639df
raoufswe
approved these changes
Oct 2, 2024
kevinrodrigues
approved these changes
Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
I discovered the eslint rule
@typescript-eslint/consistent-type-importsand I thought it would be good to add it to our PIE config package.Adding
typewherever possible is beneficial because it reduces the amount of code that TypeScript needs to include in the output JS; i.e., if an import is only needed to provide TS typing then JavaScript doesn't need it at all.This is the main change, everything else is just updating to adhere to the new rule.
Author Checklist (complete before requesting a review)
PIE StorybookPR preview