-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-button): DSW-2305 add tag prop which lets the button render as an anchor #1703
Conversation
🦋 Changeset detectedLatest commit: 7959852 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@xander-marjoram Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
Describe your changes (can list changeset entries if preferable)
href
,rel
andtarget
props which can be passed to the anchor elementAuthor Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - @jamieomaguire
PIE Storybook
/PIE Docs
PR previewReviewer 2
PIE Storybook
/PIE Docs
PR preview