Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-button): DSW-2305 add tag prop which lets the button render as an anchor #1703

Merged
merged 18 commits into from
Sep 2, 2024

Conversation

xander-marjoram
Copy link
Contributor

@xander-marjoram xander-marjoram commented Aug 15, 2024

Describe your changes (can list changeset entries if preferable)

  • [Added] - tag prop which lets the button render as an anchor tag
  • [Added] - href, rel and target props which can be passed to the anchor element

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@xander-marjoram xander-marjoram self-assigned this Aug 15, 2024
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 7959852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
pie-docs Patch
@justeattakeaway/pie-button Minor
pie-storybook Patch
@justeattakeaway/pie-webc-testing Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xander-marjoram xander-marjoram added work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Aug 15, 2024
@xander-marjoram xander-marjoram added design-review This PR contains changes that require a design review and removed work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Aug 27, 2024
@xander-marjoram xander-marjoram marked this pull request as ready for review August 28, 2024 08:09
@xander-marjoram xander-marjoram requested review from a team as code owners August 28, 2024 08:09
@xander-marjoram xander-marjoram removed the design-review This PR contains changes that require a design review label Aug 29, 2024
@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@xander-marjoram
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@xander-marjoram Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@jamieomaguire jamieomaguire self-requested a review August 30, 2024 07:05
@xander-marjoram xander-marjoram merged commit 7de240b into main Sep 2, 2024
40 of 41 checks passed
@xander-marjoram xander-marjoram deleted the dsw-2305-button-anchor-tag branch September 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants