Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-monorepo): DSW-2362 updated button test and ci percy debug #1707

Closed
wants to merge 21 commits into from

Conversation

JoshuaNg2332
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@JoshuaNg2332 JoshuaNg2332 added work-in-progress This pull request is still a work in progress and may not be ready for review DO NOT MERGE labels Aug 16, 2024
@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners August 16, 2024 15:05
Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: add8a75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Aug 16, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against add8a75

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1707 August 16, 2024 15:13 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1707 August 30, 2024 10:31 Inactive
@github-actions github-actions bot added the ci label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci components DO NOT MERGE pie-button work-in-progress This pull request is still a work in progress and may not be ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants