feat(pie-docs): DSW-2268 adds dynamic display of index page cards #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4791ed8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maledr5
changed the title
maledr5
force-pushed
the
DSW-2268-docs-index-page-nav
branch
from
9da2828 to
c36fc0a
Compare
throws error when image is not provided and adds support for 320 screens
raoufswe
approved these changes
Sep 9, 2024
fernandofranca
approved these changes
Sep 9, 2024
maledr5
added a commit
that referenced
this pull request
Sep 11, 2024
* feat(pie-docs): DSW-2268 refactors navigation to include link to index pages * feat(pie-docs): DSW-2268 removes resize observer to apply changes on mobile version * chore(pie-docs): DSW-2268 update changesets file * fix(pie-docs): DSW-2268 avoids animation when clicking on the same category * fix(pie-docs): DSW-2268 remove accordion animation for links * feat(pie-docs): DSW-2268 adds dynamic display of index page cards (#1730) * feat(pie-docs): DSW-2268 adds dynamic display of index page cards * feat(pie-docs): DSW-2268 adds hover animation for cards * feat(pie-docs): DSW-2268 adds images for index page * test(pie-docs): DSW-2268 update snapshot with latest changes * docs(pie-docs): DSW-2268 adds missing images and changeset file * feat(pie-docs): DSW-2268 ingnore items for draft pages * chore(pie-docs): DSW-2268 update documentation about new feature * fix(pie-docs): DSW-2268 address PR comments throws error when image is not provided and adds support for 320 screens * fix(pie-docs): DSW-2268 fix nav for subpage dropdown items * fix(pie-docs): DSW-2268 address PR comments * fix(pie-docs): DSW-2268 adds empty alt attribute for image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
Created a shortcode that will display a card for each element in the navigation under a category.
A category is a main navigation item like
ComponentsorFoundations.This shortcode can be used as content for the Category page when we support one. Currently this PR adds support for components, and a new will be implementing Foundations.
Future updates will only need to add the image to assets, or ignore any items that are not supposed to be displayed.
Author Checklist (complete before requesting a review)
Reviewer checklists (complete before approving)
Reviewer 1 - @jamieomaguire
Reviewer 2