Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-lottie-player): DSW-2365 implement lottie player (dev pr) #1733

Closed
wants to merge 17 commits into from

Conversation

fernandofranca
Copy link
Contributor

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: e61ac6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@justeattakeaway/pie-lottie-player Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fernandofranca
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@fernandofranca Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@fernandofranca
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@fernandofranca Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

feat(pie-lottie-player): DSW-2365 add props

feat(pie-lottie-player): DSW-2365 add lottie-web library

feat(pie-lottie-player): DSW-2365 implement fields and methods

feat(pie-lottie-player): DSW-2365 improve error handling

feat(pie-lottie-player): DSW-2365 remove unnecessary style
feat(pie-lottie-player): DSW-2365 update loop and play to use getters and setters

feat(pie-lottie-player): DSW-2365 implement speed and direction as getters/setters

feat(pie-lottie-player): DSW-2365 assign type
…tings are kept when

a new animation is loaded

feat(pie-lottie-player): DSW-2365 fix speed and direction issue

feat(pie-lottie-player): DSW-2365 reverse loop and autoplay props

feat(pie-lottie-player): DSW-2365 fix wording

feat(pie-lottie-player): DSW-2365 fix play issue

feat(pie-lottie-player): DSW-2365 sort out issue with autoplay
feat(pie-lottie-player): DSW-2365 fix wording
feat(pie-lottie-player): DSW-2365 fix async issues
@fernandofranca
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@fernandofranca Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@fernandofranca fernandofranca changed the title feat(pie-lottie-player): DSW-2365 implement lottie player feat(pie-lottie-player): DSW-2365 implement lottie player (dev pr) Sep 2, 2024
@fernandofranca
Copy link
Contributor Author

After so many updates it became a bit messy, I'm closing it to open a clean one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants