-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-divider): DSW-2286 add label to pie-divider #1746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 226013a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leksaBoiko
commented
Aug 29, 2024
packages/components/pie-divider/test/component/pie-divider.spec.ts
Outdated
Show resolved
Hide resolved
ashleynolan
reviewed
Sep 2, 2024
xander-marjoram
previously approved these changes
Sep 2, 2024
ashleynolan
previously approved these changes
Sep 2, 2024
ashleynolan
reviewed
Sep 2, 2024
ashleynolan
reviewed
Sep 2, 2024
leksaBoiko
dismissed stale reviews from ashleynolan and xander-marjoram
via
September 2, 2024 14:15
226013a
ashleynolan
approved these changes
Sep 2, 2024
xander-marjoram
approved these changes
Sep 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
[Added] -
label
property topie-divider
[Added] -
Labelled
story and a storybook control for thelabel
propertyFeature url: here
Design for the new variant can be found: here
Author Checklist (complete before requesting a review)
PIE Storybook
PR previewReviewer checklists (complete before approving)
Reviewer 1 - @xander-marjoram
PIE Storybook
PR previewReviewer 2 – @ashleynolan
PIE Storybook
PR preview