Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-divider): DSW-2286 add label to pie-divider #1746

Merged
merged 11 commits into from
Sep 2, 2024

Conversation

leksaBoiko
Copy link
Contributor

@leksaBoiko leksaBoiko commented Aug 29, 2024

Describe your changes (can list changeset entries if preferable)

[Added] - label property to pie-divider
[Added] - Labelled story and a storybook control for the label property

Feature url: here
Design for the new variant can be found: here

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.

Reviewer checklists (complete before approving)

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 – @ashleynolan

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 226013a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
pie-storybook Minor
@justeattakeaway/pie-divider Minor
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

xander-marjoram
xander-marjoram previously approved these changes Sep 2, 2024
ashleynolan
ashleynolan previously approved these changes Sep 2, 2024
@leksaBoiko leksaBoiko merged commit 8566e90 into main Sep 2, 2024
40 of 41 checks passed
@leksaBoiko leksaBoiko deleted the dsw-2286-devider-label branch September 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants