Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-lottie-player): DSW-2365 implement lottie player #1763

Merged
merged 34 commits into from
Sep 10, 2024

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Sep 2, 2024

Describe your changes (can list changeset entries if preferable)

@justeattakeaway/pie-lottie-player

[Added] - component for playing Lottie animation files

pie-storybook

[Added] - story and controls for pie-lottie-player

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • If visual tests are required for the component, I have created a project in Percy
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application
  • I have created a new label and added it to the PR Labeler workflow

Reviewer checklists (complete before approving)

Reviewer 1 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @xander-marjoram

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 9804b8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
pie-storybook Patch
@justeattakeaway/pie-lottie-player Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire
Copy link
Contributor

Amazing work @fernandofranca! Just left some comments/thoughts 👍

feat(pie-lottie-player): DSW-2365 code review updates
@fernandofranca fernandofranca merged commit 2989a05 into main Sep 10, 2024
56 of 58 checks passed
@fernandofranca fernandofranca deleted the dsw-2365-lottie-player branch September 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants