-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-lottie-player): DSW-2365 implement lottie player #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9804b8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fernandofranca
force-pushed
the
dsw-2365-lottie-player
branch
from
September 3, 2024 08:02
144af95
to
d35053d
Compare
Amazing work @fernandofranca! Just left some comments/thoughts 👍 |
fernandofranca
commented
Sep 4, 2024
packages/components/pie-lottie-player/test/accessibility/pie-lottie-player.spec.ts
Outdated
Show resolved
Hide resolved
packages/components/pie-lottie-player/test/visual/pie-lottie-player.spec.ts
Outdated
Show resolved
Hide resolved
fernandofranca
force-pushed
the
dsw-2365-lottie-player
branch
from
September 4, 2024 12:44
ab2bbc0
to
0f149be
Compare
fernandofranca
force-pushed
the
dsw-2365-lottie-player
branch
from
September 4, 2024 13:33
0f149be
to
2cf382c
Compare
fernandofranca
force-pushed
the
dsw-2365-lottie-player
branch
from
September 4, 2024 13:48
2cf382c
to
2230358
Compare
…ets to build folder
This reverts commit ea1ceb5.
feat(pie-lottie-player): DSW-2365 code review updates
fernandofranca
force-pushed
the
dsw-2365-lottie-player
branch
from
September 10, 2024 14:11
089d43d
to
9804b8d
Compare
xander-marjoram
approved these changes
Sep 10, 2024
dandel10n
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
@justeattakeaway/pie-lottie-player
[Added] - component for playing Lottie animation files
pie-storybook
[Added] - story and controls for pie-lottie-player
Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - @jamieomaguire
PIE Storybook
/PIE Docs
PR previewReviewer 2 - @xander-marjoram
PIE Storybook
/PIE Docs
PR preview