Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-select): DSW-2765 generate component skeleton #2224

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Feb 17, 2025

Describe your changes (can list changeset entries if preferable)

  • Scaffold pie-select component

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • [-] If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @raoufswe

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@fernandofranca fernandofranca requested review from a team as code owners February 17, 2025 09:00
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 6040ae4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-select Patch
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fernandofranca fernandofranca force-pushed the dsw-2765-pie-select-generate-skeleton branch from 6040ae4 to 3575cc7 Compare February 19, 2025 07:45
@fernandofranca fernandofranca merged commit bd9bc87 into main Feb 19, 2025
56 of 57 checks passed
@fernandofranca fernandofranca deleted the dsw-2765-pie-select-generate-skeleton branch February 19, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants