Refactor(Linting): ESLint, Prettier for Acceptance Tests #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
|
In the package.json at the root of the directory, please modify the check:all script to have the lint:all instead of the lint:client. |
|
Looks like eslint was not properly installed in the acceptance directory. Install eslint and prettier into the acceptance directory so that the GitHub Action "test-pipeline.yaml" passes properly. |
|
The repository root package.json install:all command is missing a command to install dependencies in the acceptance folder. Please write a command for installing acceptance dependencies and attach it to the install:all command. |
|
Add the install:acceptance command to the install:all command in the root package.json. Use the && annotation for appending it to the end of the install:all command. |
|
Remove the install:acceptance command from the root package.json, also remove it from the install:all command within the same package.json. The GitHub test-pipeline action is still failing, saying eslint cannot be found when the lint:acceptance command is executed. Resolve this issue as well. |
|
`npm run check:all
sh: 1: eslint: not found Fix the above error that was identified from the GitHub Action, test-pipeline.yaml |
|
Modify the .prettierrc.json and .eslintec.json in the acceptance directory to match the client directory's .prettierrc.json and .eslintec.json. Ensure that the GitHub Actions under test-pipeline.yaml pass. There is an error with the npm run lint:all command, and more specifically the lint:acceptance command and execution. |
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
justinthelaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ESLint and Prettier to the
acceptancesubproject and updates the rootpackage.jsonto include linting and formatting commands for theacceptancesubproject. This ensures consistency in linting and formatting rules across theclientandacceptancesubprojects.Summary of Changes
acceptancesubproject, pointing to the existing configuration files in theclientsubproject.package.jsonto include linting and formatting commands for theacceptancesubproject.package.jsonfor linting theacceptancesubproject and linting both theclientandacceptancesubprojects.Please review and merge this PR to enable linting and formatting in the
acceptancesubproject.Fixes #110.
To checkout this PR branch, run the following command in your terminal: