Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix can not compile to web #5

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix can not compile to web #5

merged 2 commits into from
Jan 27, 2025

Conversation

boyan01
Copy link
Contributor

@boyan01 boyan01 commented Sep 5, 2024

fix error when build to web

../../../.pub-cache/hosted/pub.dev/edwards25519-1.0.4/lib/field/math/bits.dart:23:34: Error: The integer literal 0xFFFFFFFFFFFFFFFF can't be represented exactly in JavaScript.
Try changing the literal to something that can be represented in JavaScript. In JavaScript 0x10000000000000000 is the nearest value that can be represented exactly.
        ((x1 * y1) & BigInt.from(0xFFFFFFFFFFFFFFFF)) + w2 + ((w1 >> 32));
                                 ^^^^^^^^^^^^^^^^^^

ref:

https://github.com/justkawal/edwards25519/blob/main/lib/field/math/bits.dart#L35

@boyan01 boyan01 requested a review from justkawal as a code owner September 5, 2024 05:33
justkawal
justkawal previously approved these changes Sep 19, 2024
@justkawal justkawal enabled auto-merge September 19, 2024 14:57
@justkawal
Copy link
Owner

@boyan01 Approved.
Just might need to format with command: dart format .

auto-merge was automatically disabled September 20, 2024 03:23

Head branch was pushed to by a user without write access

@boyan01
Copy link
Contributor Author

boyan01 commented Sep 20, 2024

@justkawal format fixed

@justkawal justkawal self-requested a review January 27, 2025 02:02
@justkawal justkawal merged commit e4b7f0f into justkawal:main Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants