Remote twitch emote API #2828
Merged
Remote twitch emote API #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we just need the code and the ID, which are already present in the chat message. There's no need to perform an API call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used twitchemotes.com to fetch data about each twitch emote as it was used. This stopped working at some point, probably because they changed their (undocumented) API somehow.
Turns out we actually don't need to use that service anyway, since the only info we need is the ID and the code, both of which are present in the chat message. So in this PR I remove that and update the chat parser to extract twitch emotes automatically.
This should address one of the more common sentry errors we're seeing and hopefully do a better job of keeping us well beneath our error limit there.