Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from anywhere #604

Merged
merged 20 commits into from
Jul 30, 2024
Merged

Import from anywhere #604

merged 20 commits into from
Jul 30, 2024

Conversation

georg-schwarz
Copy link
Member

Closes #593

@georg-schwarz
Copy link
Member Author

georg-schwarz commented Jul 26, 2024

Ran into a roadblock in the implementation. The interpreter somehow doesn't pick up the hook added it seems. Asked for help in eclipse-langium/langium#1308 (comment)

@georg-schwarz georg-schwarz force-pushed the 593-import-from-anywhere branch from 4674296 to 641d3be Compare July 26, 2024 11:53
@georg-schwarz georg-schwarz force-pushed the 593-import-from-anywhere branch from 953ec48 to 835f9ca Compare July 26, 2024 13:30
@georg-schwarz georg-schwarz requested review from rhazn and joluj July 26, 2024 13:41
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the code itself looks fine to me, I still get errors trying to run models with imports from above them if the interpreter runs from the same directory as the model:

error: Import from "./../../shared/transforms.jv" could be resolved. Check if the file exists in the given location.
$In <path removed>model.jv:15:8
15 | } from "./../../shared/transforms.jv";

@georg-schwarz georg-schwarz requested a review from rhazn July 29, 2024 13:59
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works on my machine :).

@georg-schwarz georg-schwarz merged commit dfcc6b2 into main Jul 30, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the 593-import-from-anywhere branch July 30, 2024 06:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Imports from Anywhere on the FS
2 participants