Update to axum 0.7, tonic 0.12, hyper 1.4, tower 0.5 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
avsaase
commented
Sep 17, 2024
Comment on lines
40
to
56
| /// ```ignore | ||
| /// use tower::{builder::ServiceBuilder, make::make_service::shared::Shared}; | ||
| /// use axum::Server; | ||
| /// | ||
| /// use axum_tonic::RestGrpcService; | ||
| /// use tokio::net::TcpListener; | ||
| /// use tower::ServiceBuilder; | ||
| /// | ||
| /// let svc: RestGrpcService = my_service(); | ||
| /// | ||
| /// | ||
| /// let svc_with_layers = ServiceBuilder::new() | ||
| /// .buffer(5) | ||
| /// .layer(my_layer1()) | ||
| /// .layer(my_layer2()) | ||
| /// .service(svc); | ||
| /// | ||
| /// Server::bind(&"127.0.0.1:3000".parse().unwrap()) | ||
| /// .serve(Shared::new(svc_with_layers)) | ||
| /// | ||
| /// axum::serve(TcpListener::bind(&"127.0.0.1:3000"), svc_with_layers) | ||
| /// .await | ||
| /// .unwrap(); | ||
| /// ``` |
There was a problem hiding this comment.
This example doesn't make sense to me as it doesn't use the function that it is supposed to document. I updated it anyway but I'm happy to make changes if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8