-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nifi 2.0.0 #767
add nifi 2.0.0 #767
Conversation
🔍 diffoscope analysis uploaded to https://github.com/jvm-repo-rebuild/reproducible-central/actions/runs/12009905632
|
locale=en_US | ||
umask=002 | ||
|
||
command="mvn -Papache-release,include-grpc,include-ranger clean package -DskipTests -Dmaven.javadoc.skip -Dgpg.skip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hboutemy For reference in the next release version, NiFi now uses the Maven Wrapper command mvnw
, which should improve reproducibility by ensuring the same version of Maven. In addition, the include-grpc
and include-ranger
profiles are no longer part of the NiFi 2.0 build process, so they can be removed. Thanks for continuing to track reproducibility for NiFi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the hint: testing in #836
adding new releases is easy by copying previous recipe, getting your help on adapting is very useful
we'll now need to find each small improvement we can do on the remaining RB issues: for example, I now remember I use your project as an example https://github.com/apache/nifi/pull/6500/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 but the result is incomplete...
one nice thing to do at project level is to share rebuild result during vote process: don't fail the vote on remaining issues, but it's just an opportunity to share and celebrate improvements
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/nifi/nifi/README.md