-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdm): support lock-spec >=4.5 #122
base: main
Are you sure you want to change the base?
Conversation
@@ -58,6 +58,11 @@ def get_development_dependencies(lock: Dict[str, Any]) -> Dict[str, List[Require | |||
return {group: [Requirement(EDITABLE_PATTERN.sub("", dep)) for dep in deps] for group, deps in dep_groups.items()} | |||
|
|||
|
|||
def get_excluded_packages(lock: Dict[str, Any]) -> List[str]: | |||
packages = lock.get("tool", {}).get("pdm", {}).get("resolution", {}).get("excludes", []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this section? Do you have an example lock file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we make use of tool.pdm.resolution.excludes.
packages listed there will also not be contained in the lockfile, that's why i explicitly filter them out here.
I'm not completely sure if this is required or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. So this seems orthogonal to the multi-platform issue from #115, right? If that's the case, I don't have a problem with this change. It seems like we'll need to handle both cases.
Do you know why the tests are failing?
I have the same issue. This workaround let me move forward but I can't migrate to Bazel 8. |
Because of these rules? There have been some recent Bazel 8 fixes, although they haven't been released to BCR yet. |
i think this workaround is far from correct. |
Agreed and I'm starting to doubt this is actually the source of my issue. I tried
|
We're now running into similar issues as #115.
I know this change is most likely insufficient, but unblocks us for now.
let's take this as a starting point for discussion :)