Fix handling of inline tags that span across block tags

Change-Id: I7378d00f977142e638c9a29aa5e2f3896a3e6e5e
jwbth · Nov 7, 2024 · 02dae36 · 02dae36
1 parent 7f1e9fe
commit 02dae36
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/CommentSkeleton.js b/src/CommentSkeleton.js
@@ -847,12 +847,11 @@ class CommentSkeleton {
           }
         }
 
-        // We should only enclose if there is need: there is at least one inline or non-empty text
-        // node in the sequence.
-        if (
-          !encloseThis &&
-          ((part.isTextNode && part.node.textContent.trim()) || isInline(part.node))
-        ) {
+        // We should only enclose if there is a need: there is at least one inline or non-empty text
+        // node in the sequence. Trimming is needed for cases like
+        // https://en.wikipedia.org/wiki/Special:GoToComment/c-Tazerdadog-20241102185300-Ratnahastin-20241102181500#undefined
+        // where the parser leaves <s> </s> (<span> </span> for Parsoid) between <dd> tags.
+        if (!encloseThis && isInline(part.node, true) && part.node.textContent.trim()) {
           encloseThis = true;
         }
       } else {