-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Template Task with Arguments #372
base: master
Are you sure you want to change the base?
Conversation
Hmm, I wonder... have I broken the test suites again 😠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why the tests are failing, but I guess you figure out tomorrow morning or so.. 😜
Just had one reflection while looking at this
export interface TaskRunnerItem { | ||
description: string; | ||
command: string; | ||
arguments?: CommandParameter[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unknown[]
maybe?
I think we have quite a challenge here... (not only with your test...) I don't know if we could support arguments of other than simple data types, and (meaningful) commands with only simple data types seems to be a bit rare (at least the built-in commands)... Maybe we need to let the user provide a datatype (from a list of supported ones), and we cast them before sending them to the |
This could get interesting... I guess we would need to define the structure of the supported data types in the syntax.json as well? Otherwise we would cast from an object with unknown properties. |
Exactly... The most obvious one to support is Uri (see https://code.visualstudio.com/api/references/commands for built-in commands)
|
Related to #324.
Changes proposed in this pull request:
Additional comments
Ehm... don't let the commit history fool you. Branched out of the dev branch for #324.