Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / live channels screen with EPG view #113

Merged
merged 102 commits into from
Aug 5, 2022

Conversation

ChristiaanScheermeijer
Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer commented Jul 15, 2022

This PR will be used as the "main" branch for the EPG feature

@marcovandeveen I've mapped the scope from #24 to the planned features. Let me know if you need changes here.

Planning

Must have

  • ✅ Desktop + mobile support
  • ✅ EPG data delivery from a remote URL
  • ✅ Multiple channels (3-5 channels is sweet spot)
  • ✅ Visualize EPG in local timezone
  • ✅ Broadcast Live 24x7 Streams
  • ✅ Play current live items
  • ✅ Scroll back in the current program (DVR - default 5 mins) (managed from the streaming dashboard)

Should have

  • ✅ Play historical live items (Catchup - default 8 hours)
  • ✅ Deal with EPG longer than catchup service
  • ⚠️ Scroll through future / past (max 7 days) (multiple days don't work well in EPG)
  • ✅ See in OTT Analytics that the 'playlist' source was EPG
  • ✅ Demo mode
  • ✅ Support for live streams without valid EPG data / URL (show continuous line empty timeline)
  • 🅿️ Link to JW VOD item OR series item (parked)
  • ✅ Start from the beginning

Nice-to-have

  • 🅿️ Right-to-live support text of text
  • 🅿️ Select (long-term) future date
  • ✅ Program-level images
  • 🅿️ Translation support
  • 🅿️ Option to visualize EPG in an absolute timezone

📝 = planned
🅿️ = not planned
🏗️ = in progress
⚠️ = impediment(s)
✅ = finished

@github-actions
Copy link

github-actions bot commented Jul 15, 2022

Visit the preview URL for this PR (updated for commit 549bdf4):

https://ottwebapp--pr113-feat-live-channels-v-wd5e3dk5.web.app

(expires Sat, 03 Sep 2022 13:21:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@marcovandeveen marcovandeveen marked this pull request as ready for review July 15, 2022 10:21
@marcovandeveen
Copy link
Member

Sorry, pressed "ready for review" button on accident!

@marcovandeveen
Copy link
Member

marcovandeveen commented Jul 15, 2022

Wow Christiaan, you are aiming high with this planned scope!

Note about "See in OTT Analytics that the 'playlist' source was EPG"
In the current solution direction, it means feeding analytics parameter fed (Feed ID) attribute with the EPG source playlist.

@marcovandeveen marcovandeveen marked this pull request as draft July 15, 2022 10:35
@marcovandeveen
Copy link
Member

marcovandeveen commented Jul 15, 2022

@ChristiaanScheermeijer

@AntonLantukh highlighted an item we didn't discuss: "open live channel from homepage shelf". It's currently opening the movie page. But should now open the "live" page, with the right channel selected.

Could be based on scheduleURL (similar to opening series, based on seriesId).

I added to the 'must have' scope. Could you factor this into your plan? I think it's more important than having images in the schedule or Link to JW VOD item OR series item. (in case we need to choose)

@ChristiaanScheermeijer
Copy link
Collaborator Author

Thanks @marcovandeveen

Ah, then I guess adding the OTT analytics fed property is an easy win. I will add it to the playback tickets 💪

When adding live media items to the homepage, we'll be missing the containing playlist id. This is needed in order to get all channels. There is no concrete reference to this value at the moment.

However, if you add the Live playlist as a shelf, we can deep link to the live screen with the live channel selected.

But it would also be nice when it's possible to promote live channels in the featured shelf...

@ChristiaanScheermeijer ChristiaanScheermeijer changed the title feat(project): live channels screen with EPG view Feat / live channels screen with EPG view Aug 1, 2022
@ChristiaanScheermeijer ChristiaanScheermeijer marked this pull request as ready for review August 1, 2022 15:40
@ChristiaanScheermeijer
Copy link
Collaborator Author

@dbudzins we'll be testing this deploy preview tomorrow. In addition, @RCVZ will submit a PR this evening or tomorrow as well with some automated tests for the live channels page.

Most of the code is already reviewed in the previous PRs, but please let us know if you have feedback.

@dbudzins dbudzins merged commit 3c84877 into develop Aug 5, 2022
@dbudzins dbudzins deleted the feat/live-channels-view-with-epg branch November 10, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants