-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / live channels screen with EPG view #113
Conversation
Visit the preview URL for this PR (updated for commit 549bdf4): https://ottwebapp--pr113-feat-live-channels-v-wd5e3dk5.web.app (expires Sat, 03 Sep 2022 13:21:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sorry, pressed "ready for review" button on accident! |
Wow Christiaan, you are aiming high with this planned scope! Note about "See in OTT Analytics that the 'playlist' source was EPG" |
@AntonLantukh highlighted an item we didn't discuss: "open live channel from homepage shelf". It's currently opening the movie page. But should now open the "live" page, with the right channel selected. Could be based on scheduleURL (similar to opening series, based on seriesId). I added to the 'must have' scope. Could you factor this into your plan? I think it's more important than having images in the schedule or Link to JW VOD item OR series item. (in case we need to choose) |
Thanks @marcovandeveen Ah, then I guess adding the OTT analytics When adding live media items to the homepage, we'll be missing the containing playlist id. This is needed in order to get all channels. There is no concrete reference to this value at the moment. However, if you add the Live playlist as a shelf, we can deep link to the live screen with the live channel selected. But it would also be nice when it's possible to promote live channels in the featured shelf... |
d70c215
to
325f92f
Compare
325f92f
to
a06ee35
Compare
…oken Feat / add support for schedule token
Feat / fill schedule with static program when empty
Feat / add EPG service and data fixtures
Fix/epg fixes and improvements
with seeElement
animation
Feat / add live channel e2e tests
This PR will be used as the "main" branch for the EPG feature
@marcovandeveen I've mapped the scope from #24 to the planned features. Let me know if you need changes here.
Planning
Must have
Should have
show continuous lineempty timeline)Nice-to-have
📝 = planned
🅿️ = not planned
⚠️ = impediment(s)
🏗️ = in progress
✅ = finished